feat(rules): add prefer-strict-equal #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The desire to make strict equality the default behaviour has been discussed. This rule at least makes it enforceable. Maybe this should be a part of the |
tryggvigy
force-pushed
the
prefer-strict-equal
branch
from
1bfcd98 to
d7c2c33
Compare
SimenB
reviewed
Aug 9, 2018
docs/rules/prefer-strict-equal.md
Outdated
| # Suggest using `toStrictEqual()` (prefer-strict-equal) | ||
|
|
||
| `toStrictEqual` not only checks that two objects contain the same data but also | ||
| that they have the same shape. The believe is that imposing a stricter equality |
Member
There was a problem hiding this comment.
"The believe is that" sounds odd. Could you re-phrase?
Contributor
Author
There was a problem hiding this comment.
I tweaked and expanded on this a bit in a7ca3b2
SimenB
requested changes
Aug 9, 2018
Member
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
Thanks for sending a PR! Left some comments in the docs, code LGTM
docs/rules/prefer-strict-equal.md
Outdated
|
|
||
| This rule triggers a warning if `toEqual()` is used to assert equality. | ||
|
|
||
| This rule is enabled by default. |
Also remove mention of the rule being enabled by default. It's not
Member
|
Thanks! |
Member
|
🎉 This PR is included in version 21.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Aug 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will
Implement the
prefer-strict-equalrule. This rule serves to encourage stricter equality checks on objects.Why?
The believe is that imposing stricter equality results in safer tests.