[Bug]: v30 alpha: `testPathPatterns` that worked in the past not working any more.

[phryneas]

Version

30.0.0-alpha.2

Steps to reproduce

yarn jest --config ./config/jest.config.js useLoadableQuery

Expected behavior

Jest finds the matching file src/react/hooks/__tests__/useLoadableQuery.test.tsx and executes it

Actual behavior

No tests found, exiting with code 1

Additional context

I understand that jest 30 had a change (in #12519) from a [TestPathPattern] option to [TestPathPatterns], but honestly, I'm failing to get anything to match this new option, even specifying the full path to the test doesn't work.

From the issue, it seems like this doesn't accept a RegEx anymore, but an array of patterns - but I'm not sure how to write those patterns. I'm getting errors like Invalid testPattern **/useLoadableQuery.* supplied. Running all tests instead..

This might be user error, but this change is very unexpected, and will probably seriously impact the workflows of most jest users and a ton of CI scripts, so I thought I'd open an issue to bring this to your attention.

Environment

System:
    OS: macOS 13.6
    CPU: (8) arm64 Apple M1 Pro
  Binaries:
    Node: 20.5.0 - ~/.nvm/versions/node/v20.5.0/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 9.8.0 - ~/.nvm/versions/node/v20.5.0/bin/npm
    pnpm: 8.7.6 - /opt/homebrew/bin/pnpm
  npmPackages:
    jest: 30.0.0-alpha.2 => 30.0.0-alpha.2

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

[SimenB]

Do you have a full reproduction?

[phryneas]

@SimenB I would assume that this literally happens in every project using jest - it's just a completely different file name matching logic than before now.

But if this is actually some edge case and not intended to happen, I can create a branch of the Apollo Client repo with jest 30 after the new year; it definitely happened there, but I rolled back without creating a commit/branch, because it was completely unusable.

[SimenB]

It does not happen in this very repo, at least 🙂

[phryneas]

I'll try to reproduce it once I'm back at the job :)

[SimenB]

Cool 👍 Enjoy your vacation!

Ideally the reproduction is not the entire @apollo/client 😅

[phryneas]

So the easy (for me) reproduction is unfortunately @apollo/client 😓

Check out
https://github.com/apollographql/apollo-client/tree/reproduction/jest-30-alpha

and run

npm i
node --expose-gc ./node_modules/jest/bin/jest.js --config ./config/jest.config.js useSuspense

which will error with (I ran it with --verbose here)

No tests found, exiting with code 1
Run with --passWithNoTests to exit with code 0
In /Users/tronic/tmp/apollo-client/src
379 files checked.
testMatch: /tests//.?([mc])[jt]s?(x), **/?(.)+(spec|test).?([mc])[jt]s?(x) - 142 matches
testPathIgnorePatterns: .tsx$ - 317 matches
testRegex: - 0 matches
In /Users/tronic/tmp/apollo-client/src
379 files checked.
testMatch: /tests//.?([mc])[jt]s?(x), **/?(.)+(spec|test).?([mc])[jt]s?(x) - 142 matches
testPathIgnorePatterns: .ts$, src/react/hooks/tests/useSuspenseQuery.test.tsx, src/react/hooks/tests/useBackgroundQuery.test.tsx, src/react/hooks/tests/useLoadableQuery.test.tsx, src/react/hooks/tests/useQueryRefHandlers.test.tsx, src/react/query-preloader/tests/createQueryPreloader.test.tsx - 75 matches
testRegex: - 0 matches
In /Users/tronic/tmp/apollo-client/src
379 files checked.
testMatch: /tests//.?([mc])[jt]s?(x), **/?(.)+(spec|test).?([mc])[jt]s?(x) - 142 matches
testPathIgnorePatterns: .ts$ - 80 matches
testRegex: - 0 matches
Pattern: useSuspense - 0 matches

The test setup here contains three projects, and the third one should match the file src/react/hooks/__tests__/useSuspenseQuery.test.tsx.

I'll try if I can distill this down to a smaller reproduction, but already wanted to post this here :)

[phryneas]

I found the issue, and it has nothing to do with the new name matching!

The config file is in config/jest.config.js and has rootDir: "src".

In the past, that just worked, but version 30 is now looking in config/src, not in src.

I'm not sure - I did not see this pointed out in the changelog, but I might have missed it.

In case it's not there, it might be a good idea to point this change out, but feel free to close this issue if it's not actionable :)

See next post.

[phryneas]

Follow-up:

"../src" doesn't work as soon as I get projects involved again:

● Validation Error:

Directory ../src in the rootDir option was not found.

So I switched it over to

   rootDir: `${__dirname}/../src`,

and it's failing to find the tests again.

So this might actually not be resolved? Do any alarm bells ring for you in combination with projects?

[phryneas]

I believe I found it!

If you have a config file in a different folder, testPathPatterns are built relative to that folder and not the root folder:

The /config should not be part of the pattern here.