Jest 23 coverage failure for findRelatedTests

[bugzpodder]

Jest 23 introduced --findRelatedTests --coverage working together.
I think it doesn't work in an edge case, where if I run
jest --coverage --findRelatedtests src/abc.spec.js
abc.spec.js itself doesn't contribute to coverage count, hence coverage is 0 and the test fails.
jest --coverage --findRelatedtests src/abc.js src/abc.spec.js
This works as expected.
@stipsan

[stipsan]

Hey!

Can you make a repo that reproduces it?

Thanks 😄

[bugzpodder]

absolutely, just give me till end of the day, wanted to file this first :)
Thanks for the PR implementing this!

[stipsan]

Yeah sure, no problem! 😄

[bugzpodder]

@stipsan
https://github.com/bugzpodder/prime-factorization

Exit code 0:
./node_modules/.bin/jest --coverage
./node_modules/.bin/jest --coverage --findRelatedTests prime-factorization.test.js prime-factorization.js

Exit code 1:
./node_modules/.bin/jest --coverage --findRelatedTests t.js
./node_modules/.bin/jest --coverage --findRelatedTests prime-factorization.test.js
./node_modules/.bin/jest --coverage --findRelatedTests prime-factorization.test.js prime-factorization.js t.js

[stipsan]

Hey @bugzpodder, sorry for the overdue response!

Thanks for the repro, I looked at it and I think I understand what you’re saying.

Since t.js is negated in collectCoverageFrom it shouldn’t be included when combining —findRelatedTests and —coverage.

I’ll work on a fix this week and ping you back 😄

[stipsan]

@bugzpodder I finally got around to create a fix, checkout #6736 for details 🙂

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.