Add jest-resolve to resolve modules based on the Facebook module resolution algorithm.
#1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
cpojer
force-pushed
the
master
branch
5 times, most recently
from
6c369de to
3c35bbb
Compare
Member
Author
|
@facebook-github-bot import |
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
Member
Author
|
cc @davidaurelio, as always for these kind of things :) |
…solution algorithm.
Contributor
|
oh man, I’m sorry. I totally lost sight of this. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors Runtime.js and TestRunner.js and pulls out the resolution code into a new module
jest-resolvewhich now encodes Facebook's module resolution algorithm. It provides the second half of node-haste and together withjest-haste-mapcan be seen as a full replacement.There is very little new code in this diff. Most code is existing code that was lifted from another module and brought together. The next step after this diff will be to see if it makes sense to fork the
resolvemodule and speed up how it works.It doesn't come with its own tests (yet) because its functionality is completely covered by all the tests in Runtime.js. I have also cleaned up all of the Runtime tests and added a new
createRuntimehelper for testing, which should make it much easier from now on to change how an instance of Runtime is constructed for tests.