chore(jest-util): replace p-limit with inline implementation#15972
Open
roli-lpci wants to merge 2 commits intojestjs:mainfrom
Open
chore(jest-util): replace p-limit with inline implementation#15972roli-lpci wants to merge 2 commits intojestjs:mainfrom
roli-lpci wants to merge 2 commits intojestjs:mainfrom
Conversation
Move the concurrency-limiting logic from the p-limit package into jest-util as a ~30-line inline implementation covering the exact API surface Jest uses. This removes p-limit (and its transitive yocto-queue dependency) from jest-changed-files, jest-circus, jest-jasmine2, and jest-runner. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
babel-jest
babel-plugin-jest-hoist
babel-preset-jest
create-jest
@jest/diff-sequences
expect
@jest/expect-utils
jest
jest-changed-files
jest-circus
jest-cli
jest-config
@jest/console
@jest/core
@jest/create-cache-key-function
jest-diff
jest-docblock
jest-each
@jest/environment
jest-environment-jsdom
@jest/environment-jsdom-abstract
jest-environment-node
@jest/expect
@jest/fake-timers
@jest/get-type
@jest/globals
jest-haste-map
jest-jasmine2
jest-leak-detector
jest-matcher-utils
jest-message-util
jest-mock
@jest/pattern
jest-phabricator
jest-regex-util
@jest/reporters
jest-resolve
jest-resolve-dependencies
jest-runner
jest-runtime
@jest/schemas
jest-snapshot
@jest/snapshot-utils
@jest/source-map
@jest/test-result
@jest/test-sequencer
@jest/transform
@jest/types
jest-util
jest-validate
jest-watcher
jest-worker
pretty-format
commit: |
The p-limit removal in jasmineAsyncInstall.ts collapsed two import lines into one, shifting all subsequent line numbers in the built index.js by -1. This updates the snapshot references from line 311 to 310. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the
p-limitpackage (and its transitiveyocto-queuedependency) with a ~30-line inline concurrency limiter injest-util. The implementation covers the exact API surface Jest uses:pLimit(n)returning a function that queues async work with bounded concurrency.Packages updated:
jest-changed-files— process-spawning mutex (concurrency 5)jest-circus— concurrent test limiterjest-jasmine2— concurrent test limiterjest-runner— in-band and parallel test run limitersThe e2e test fixture (
e2e/transform/transform-runner/runner.ts) still usesp-limitdirectly from the root devDependencies, which is appropriate for a test fixture.Test plan
yarn build:jscompiles cleanlyyarn constraintspassesyarn dedupe --checkpasses