Skip to content

Check if the maxWorkers has a value and raises an exception otherwise #4591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 3 commits into from
Oct 3, 2017
Merged

Check if the maxWorkers has a value and raises an exception otherwise #4591

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f48c6be
Check if the maxWorkers has a value and raises an exception otherwise
nicolasiensen Oct 3, 2017
07c0674
Add expected exception message in the check method tests
nicolasiensen Oct 3, 2017
2ff0f6b
Improve error message for when maxWorkers is undefined
nicolasiensen Oct 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Improve error message for when maxWorkers is undefined
  • Loading branch information
@nicolasiensen
nicolasiensen committed Oct 3, 2017
commit 2ff0f6b4fad6ecc89c176a7aa586de00b434c403
2 changes: 1 addition & 1 deletion packages/jest-cli/src/__tests__/cli/args.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ describe('check', () => {
it('raises an exception if maxWorkers is specified with no number', () => {
const argv: Argv = {maxWorkers: undefined};
expect(() => check(argv)).toThrow(
'The --maxWorkers option requires a number to be specified',
'The --maxWorkers (-w) option requires a number to be specified',
);
});

Expand Down
4 changes: 2 additions & 2 deletions packages/jest-cli/src/cli/args.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ export const check = (argv: Argv) => {

if (argv.hasOwnProperty('maxWorkers') && argv.maxWorkers === undefined) {
throw new Error(
'The --maxWorkers option requires a number to be specified.\n' +
'The --maxWorkers (-w) option requires a number to be specified.\n' +
'Example usage: jest --maxWorkers 2\n' +
'Or did you mean --watch ?',
'Or did you mean --watch?',
);
}

Expand Down