Skip to content

Implement module.parent #4614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 11 commits into from
Oct 7, 2017
Merged

Implement module.parent #4614

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cd3becf
Implement module.parent.require
SimenB Oct 6, 2017
e0b5bdc
Implement module.parent.filename
SimenB Oct 6, 2017
f9658fd
Implement module.parent.id
SimenB Oct 6, 2017
074ad47
Try to set parent to actual parent module
SimenB Oct 6, 2017
1d9c1a6
Fix tests
SimenB Oct 6, 2017
637a4c0
styel nit to minimize diff
SimenB Oct 6, 2017
32ba23c
Fix failing test
SimenB Oct 6, 2017
1976de4
Make module.parent a lazy getter
SimenB Oct 6, 2017
9545e9a
make `parent` enumerable
SimenB Oct 6, 2017
0d234d5
Share type definition for ModuleRegistry
SimenB Oct 6, 2017
2bd0c6d
module.parent should be null not undefined for entrypoints
SimenB Oct 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Implement module.parent.id
  • Loading branch information
@SimenB
SimenB committed Oct 6, 2017
commit f9658fd826092db2b9cc84610f9415709873d3ac
2 changes: 1 addition & 1 deletion packages/jest-runtime/src/__tests__/runtime_require_module.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ describe('Runtime requireModule', () => {
expect(exports.parent).toEqual({
exports: {},
filename: '',
id: 'mockParent',
id: '',
require: expect.any(Function),
});
}));
Expand Down
12 changes: 4 additions & 8 deletions packages/jest-runtime/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,6 @@ const getModuleNameMapper = (config: ProjectConfig) => {
return null;
};

const mockParentModule = {
exports: {},
id: 'mockParent',
};

const unmockRegExpCache = new WeakMap();

class Runtime {
Expand Down Expand Up @@ -492,16 +487,17 @@ class Runtime {

const dirname = path.dirname(filename);
localModule.children = [];
localModule.parent = mockParentModule;
localModule.paths = this._resolver.getModulePaths(dirname);
localModule.require = this._createRequireImplementation(filename, options);
localModule.parent = Object.assign({}, localModule.parent, {
localModule.parent = {
exports: {},
filename: lastExecutingModulePath,
id: lastExecutingModulePath,
require: this._createRequireImplementation(
Copy link
Member

@cpojer cpojer Oct 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't this look up the parent module in jest-runtime and use its require here, instead of creating a new require implementation?

Copy link
Member Author

@SimenB SimenB Oct 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I can access the parent module, then that'd be perfect (as that's what module.parent is in node). I didn't find it though. Halp?

Copy link
Member

@cpojer cpojer Oct 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we storing this in jest-runtime somewhere?

Copy link
Member Author

@SimenB SimenB Oct 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might be, I'll check

lastExecutingModulePath,
options,
),
});
};

const transformedFile = this._scriptTransformer.transform(
filename,
Expand Down