Skip to content

Implement node Timer api when running in node environment. #4622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 4 commits into from
Oct 8, 2017
Merged

Implement node Timer api when running in node environment. #4622

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4bfff52
Implement node Timer api when running in node environment.
skrivle Oct 7, 2017
22c673a
CR feedback, use toBeUndefined.
skrivle Oct 7, 2017
48a129f
CR feedback, turn Faketimer constructor args into an object..
skrivle Oct 7, 2017
8fe3228
tweak Faketimer tests, assert if ref/unref are actually functions.
skrivle Oct 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CR feedback, use toBeUndefined.
  • Loading branch information
@skrivle
skrivle committed Oct 7, 2017
commit 22c673a83f4ec674f4e1c251b99d7c4a02ce0027
6 changes: 3 additions & 3 deletions packages/jest-environment-node/src/__tests__/node_environment.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ describe('NodeEnvironment', () => {
const timer2 = env1.global.setInterval(() => {}, 0);

[timer1, timer2].forEach(timer => {
expect(timer.id).not.toBe(undefined);
expect(timer.ref).not.toBe(undefined);
expect(timer.unref).not.toBe(undefined);
expect(timer.id).not.toBeUndefined();
expect(timer.ref).not.toBeUndefined();
expect(timer.unref).not.toBeUndefined();
});
});
});