Skip to content

Always remove node internals from stacktraces #4695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 7 commits into from
Oct 15, 2017
Merged

Always remove node internals from stacktraces #4695

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
81d3533
Always remove node internals from stacktraces
SimenB Oct 14, 2017
1596e89
Update link to PR in changelog
SimenB Oct 14, 2017
4472f9b
Fix browser test
SimenB Oct 14, 2017
f097ece
Remove weird next_tick trace just in integration tests
SimenB Oct 14, 2017
3c294ee
Rename some regexpes
SimenB Oct 14, 2017
b4bfc53
Revert "Remove weird next_tick trace just in integration tests"
SimenB Oct 14, 2017
c68e670
Note code that can be delete when we drop support fo node 4
SimenB Oct 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename some regexpes
  • Loading branch information
@SimenB
SimenB committed Oct 14, 2017
commit 3c294ee62debf7515f0bac8b09a80fc5e56bcac7
8 changes: 4 additions & 4 deletions packages/jest-message-util/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ type StackTraceOptions = {

// filter for noisy stack trace lines
const JASMINE_IGNORE = /^\s+at(?:(?:.*?vendor\/|jasmine\-)|\s+jasmine\.buildExpectationResult)/;
const STACK_TRACE_IGNORE = /^\s+at.*?jest(-.*?)?(\/|\\)(build|node_modules|packages)(\/|\\)/;
const ANONYMOUS_TRACE_IGNORE = /^\s+at <anonymous>.*$/;
const JEST_INTERNALS_IGNORE = /^\s+at.*?jest(-.*?)?(\/|\\)(build|node_modules|packages)(\/|\\)/;
const ANONYMOUS_FN_IGNORE = /^\s+at <anonymous>.*$/;
const ANONYMOUS_PROMISE_IGNORE = /^\s+at (new )?Promise \(<anonymous>\).*$/;
const ANONYMOUS_GENERATOR_IGNORE = /^\s+at Generator.next \(<anonymous>\).*$/;
const TITLE_INDENT = ' ';
Expand Down Expand Up @@ -119,7 +119,7 @@ const removeInternalStackEntries = (lines, options: StackTraceOptions) => {
let pathCounter = 0;

return lines.filter(line => {
if (ANONYMOUS_TRACE_IGNORE.test(line)) {
if (ANONYMOUS_FN_IGNORE.test(line)) {
return false;
}

Expand Down Expand Up @@ -151,7 +151,7 @@ const removeInternalStackEntries = (lines, options: StackTraceOptions) => {
return false;
}

if (STACK_TRACE_IGNORE.test(line)) {
if (JEST_INTERNALS_IGNORE.test(line)) {
return false;
}

Expand Down