Skip to content

Add path case-insensitivity if onlyChanged option is active, fixes #4644 #4730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 10 commits into from
Nov 17, 2017
Merged

Add path case-insensitivity if onlyChanged option is active, fixes #4644 #4730

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
78dadae
Correct project directory path case on Windows
peterdanis Oct 20, 2017
c47755f
fixup! Add try-catch block with fallback
peterdanis Oct 20, 2017
af59143
Make only_changed test pass on Windows
peterdanis Oct 31, 2017
b1c3f48
Add test
peterdanis Oct 31, 2017
f3f4466
Update changelog
peterdanis Oct 31, 2017
ed855fc
fixup! Simplify original writeFiles change
peterdanis Oct 31, 2017
f6350d1
fixup! Ignore process.binding flow error
peterdanis Oct 31, 2017
4c82bb5
fixup! Use correct dir
peterdanis Oct 31, 2017
aa941c6
fixup! Fix lint error
peterdanis Oct 31, 2017
a0157e7
Merge branch 'master' into dev
cpojer Nov 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! Fix lint error
  • Loading branch information
@peterdanis
peterdanis committed Oct 31, 2017
commit aa941c65ca52c0192cfce00dc09983593f4d1a0c
6 changes: 2 additions & 4 deletions integration_tests/__tests__/only_changed.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,6 @@ test('path on Windows is case-insensitive', () => {

const modifiedDIR = path.resolve(DIR, 'outer_dir', 'inner_dir');
const incorrectModifiedDIR = path.resolve(DIR, 'OUTER_dir', 'inner_dir');
let stderr;
let stdout;

writeFiles(modifiedDIR, {
'.watchmanconfig': '',
Expand All @@ -210,7 +208,7 @@ test('path on Windows is case-insensitive', () => {
run(`${GIT} add .`, modifiedDIR);
run(`${GIT} commit -m "first"`, modifiedDIR);

({stdout} = runJest(incorrectModifiedDIR, ['-o']));
const {stdout} = runJest(incorrectModifiedDIR, ['-o']);
expect(stdout).toMatch('No tests found related to files');

writeFiles(modifiedDIR, {
Expand All @@ -220,7 +218,7 @@ test('path on Windows is case-insensitive', () => {
'file3.js': `require('./file2')`,
});

({stderr} = runJest(incorrectModifiedDIR, ['-o']));
const {stderr} = runJest(incorrectModifiedDIR, ['-o']);

expect(stderr).not.toMatch(/PASS __tests__(\/|\\)file1.test.js/);
expect(stderr).toMatch(/PASS __tests__(\/|\\)file2.test.js/);
Expand Down