Skip to content

Prevent error in pretty-format for window in jsdom test env #4750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 7 commits into from
Oct 24, 2017
Merged

Prevent error in pretty-format for window in jsdom test env #4750

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
28a5a16
Prevent error in pretty-format for window in jsdom test env
pedrottimark Oct 23, 2017
0c5e9bb
Delete global
pedrottimark Oct 23, 2017
3fbc2ac
Save file after correcting comments :(
pedrottimark Oct 23, 2017
6c00595
Edit comments after perf measurements
pedrottimark Oct 24, 2017
620e1c0
add to Fixes in changelog
pedrottimark Oct 24, 2017
c00d3e3
Resolve merge conflict in change log
pedrottimark Oct 24, 2017
87d89cf
Simplify with typeof window as suggested by SimenB
pedrottimark Oct 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add to Fixes in changelog
  • Loading branch information
@pedrottimark
pedrottimark committed Oct 24, 2017
commit 620e1c0e699bf8c942520da84890bbe056c74e78
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
* `[jest-runtime]` Move `babel-core` to peer dependencies so it works with Babel 7 ([#4557](https://github.com/facebook/jest/pull/4557))
* `[jest-util]` Fix `runOnlyPendingTimers` for `setTimeout` inside `setImmediate` ([#4608](https://github.com/facebook/jest/pull/4608))
* `[jest-message-util]` Always remove node internals from stacktraces ([#4695](https://github.com/facebook/jest/pull/4695))
* `[pretty-format]` Prevent error in pretty-format for window in jsdom test env ([#4750](https://github.com/facebook/jest/pull/4750))

### Features
* `[jest-environment-*]` [**BREAKING**] Add Async Test Environment APIs, dispose is now teardown ([#4506](https://github.com/facebook/jest/pull/4506))
Expand Down