Skip to content

Remove debug and inspect flags from the arguments sent to the child #5068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjesun merged 2 commits into from
Dec 12, 2017
Merged

Remove debug and inspect flags from the arguments sent to the child #5068

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22c4e3f
Remove `debug` and `inspect` flags from the arguments sent to the child
SimenB Dec 12, 2017
14381ee
address PR comments
SimenB Dec 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
address PR comments
  • Loading branch information
@SimenB
SimenB committed Dec 12, 2017
commit 14381eed8309fc10292cf5d9f1a0926d0727a31e
9 changes: 4 additions & 5 deletions packages/jest-worker/src/__tests__/worker.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ import {
let Worker;
let forkInterface;
let childProcess;
let properProcess;
let originalExecArgv;

beforeEach(() => {
jest.mock('child_process');
properProcess = process;
originalExecArgv = process.execArgv;

childProcess = require('child_process');
childProcess.fork.mockImplementation(() => {
Expand All @@ -43,14 +43,13 @@ beforeEach(() => {

afterEach(() => {
jest.resetModules();
// eslint-disable-next-line no-native-reassign
process = properProcess;
process.execArgv = originalExecArgv;
});

it('passes fork options down to child_process.fork, adding the defaults', () => {
const child = require.resolve('../child');

Object.assign(process, {execArgv: ['--inspect', '-p']});
process.execArgv = ['--inspect', '-p'];

new Worker({
forkOptions: {
Expand Down
1 change: 0 additions & 1 deletion packages/jest-worker/src/worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ export default class {
cwd: process.cwd(),
env: process.env,
// suppress --debug / --inspect flags while preserving others (like --harmony)
// inspired by https://github.com/rvagg/node-worker-farm/blob/f63d988c307a6805e03b1650f8ef0fb7ca6f1546/lib/fork.js
execArgv: process.execArgv.filter(v => !/^--(debug|inspect)/.test(v)),
silent: true,
},
Expand Down