Skip to content

Add an option to spawn command in a shell #5340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 6 commits into from
Jan 18, 2018
Merged

Add an option to spawn command in a shell #5340

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
24db067
Add tests for Process.js
seanpoulter Jan 18, 2018
90b4c1e
Add option to spawn command inside a shell
seanpoulter Jan 18, 2018
43428f8
Add tests for constructor, start, and closeProcess
seanpoulter Jan 18, 2018
b134dcf
Add option to spawn command in a shell
seanpoulter Jan 18, 2018
affe7bc
Add #5340 to change log
seanpoulter Jan 18, 2018
f557bce
Fix build errors
seanpoulter Jan 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix build errors
  • Loading branch information
@seanpoulter
seanpoulter committed Jan 18, 2018
commit f557bce4eb5fa788814acd48da74a2190f5fcdf0
2 changes: 1 addition & 1 deletion packages/jest-editor-support/src/Process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export const createProcess = (
const spawnOptions = {
cwd: workspace.rootPath,
env,
...options,
shell: options.shell,
};
return spawn(command, runtimeArgs, spawnOptions);
};
2 changes: 2 additions & 0 deletions packages/jest-editor-support/src/__tests__/runner.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ jest.mock('../Process');
jest.mock('child_process', () => ({spawn: jest.fn()}));
jest.mock('os', () => ({tmpdir: jest.fn()}));
jest.mock('fs', () => {
// $FlowFixMe requireActual
const readFileSync = require.requireActual('fs').readFileSync;

// Replace `readFile` with `readFileSync` so we don't get multiple threads
return {
readFile: (path, type, closure) => {
Expand Down