Skip to content

Add summary_reporter.test.js #5389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 15 commits into from
Jan 28, 2018
Merged

Add summary_reporter.test.js #5389

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
aeb8170
add special option -- for npm update command
kdnakt Jan 22, 2018
270362a
Update CHANGELOG.md
kdnakt Jan 23, 2018
d7473dd
Merge branch 'master' into fix-update-command-npm
kdnakt Jan 23, 2018
8457640
add testcase for summary_reporter.js
kdnakt Jan 24, 2018
f8b7082
Merge branch 'fix-update-command-npm' of https://github.com/kdnakt/je…
kdnakt Jan 24, 2018
80cd696
add testcase for yarn
kdnakt Jan 24, 2018
9a26ddb
Merge branch 'master' into fix-update-command-npm
kdnakt Jan 24, 2018
85d5b9d
Update CHANGELOG.md
kdnakt Jan 24, 2018
c5bdfa3
import SummaryReporter at the top
kdnakt Jan 26, 2018
210987e
remove duplicated definition of results
kdnakt Jan 26, 2018
85707c6
remove description
kdnakt Jan 26, 2018
8f99c3e
add snapshot test
kdnakt Jan 26, 2018
c2b608a
update test title
kdnakt Jan 26, 2018
38c10f8
remove duplicated line
kdnakt Jan 27, 2018
480269f
add missing attributes for test results
kdnakt Jan 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add snapshot test
  • Loading branch information
@kdnakt
kdnakt committed Jan 26, 2018
commit 8f99c3e879fa4ed9fdfde5163a256626b153099e
13 changes: 13 additions & 0 deletions packages/jest-cli/src/reporters/__tests__/__snapshots__/summary_reporter.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`npm test 1`] = `
"<bold>Snapshot Summary</>
<bold><red> › 2 snapshot tests</></> failed in 1 test suite. <dim>Inspect your code changes or run \`npm test -- -u\` to update them.</>
"
`;

exports[`yarn test 1`] = `
"<bold>Snapshot Summary</>
<bold><red> › 2 snapshot tests</></> failed in 1 test suite. <dim>Inspect your code changes or run \`yarn test -u\` to update them.</>
"
`;
12 changes: 2 additions & 10 deletions packages/jest-cli/src/reporters/__tests__/summary_reporter.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,20 +41,12 @@ test('npm test', () => {
process.stderr.write = result => results.push(result);
Copy link
Contributor

@thymikee thymikee Jan 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already done in beforeEach

const testReporter = new SummaryReporter(globalConfig);
testReporter.onRunComplete(new Set(), aggregatedResults);
expect(results[0]).toMatch('\u001b[1mSnapshot Summary\u001b[22m');
expect(results[1]).toMatch(
'\u001b[1m\u001b[31m › 2 snapshot tests\u001b[39m\u001b[22m failed in 1 test suite. ' +
'\u001b[2mInspect your code changes or run `npm test -- -u` to update them.\u001b[22m',
);
expect(results[0] + results[1]).toMatchSnapshot();
Copy link
Contributor

@thymikee thymikee Jan 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about results.join('')?

Copy link
Contributor Author

@kdnakt kdnakt Jan 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems nice idea.

});

test('yarn test', () => {
process.env.npm_config_user_agent = 'yarn';
const testReporter = new SummaryReporter(globalConfig);
testReporter.onRunComplete(new Set(), aggregatedResults);
expect(results[0]).toMatch('\u001b[1mSnapshot Summary\u001b[22m');
expect(results[1]).toMatch(
'\u001b[1m\u001b[31m › 2 snapshot tests\u001b[39m\u001b[22m failed in 1 test suite. ' +
'\u001b[2mInspect your code changes or run `yarn test -u` to update them.\u001b[22m',
);
expect(results[0] + results[1]).toMatchSnapshot();
});