Skip to content

Add diff-sequences package #5407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 11 commits into from
Feb 7, 2018
Merged

Add diff-sequences package #5407

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
659d481
Add diff-sequences package
pedrottimark Jan 27, 2018
26eb356
Update CHANGELOG.md
pedrottimark Jan 27, 2018
9e40921
Replace NOT_YET_USED with NOT_YET_SET
pedrottimark Jan 28, 2018
4f91e75
Replace utility with command
pedrottimark Jan 28, 2018
c5f8569
Tame prettier
pedrottimark Jan 28, 2018
6a1cad6
Add 4 tests
pedrottimark Jan 28, 2018
1264fb5
Replace with type cast to any
pedrottimark Jan 28, 2018
d25bf28
Fix prettier errors
pedrottimark Jan 28, 2018
91795bb
Remove export from type declarations
pedrottimark Jan 28, 2018
645994d
Correct aLength and bLength in README.md
pedrottimark Jan 28, 2018
e798c76
Merge branch 'master' into add-diff-sequences
cpojer Feb 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Replace with type cast to any
  • Loading branch information
@pedrottimark
pedrottimark committed Jan 28, 2018
commit 1264fb53c8917305f8a7fc268b9d20a35b2ab485
9 changes: 3 additions & 6 deletions packages/diff-sequences/src/__tests__/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ describe('invalid arg', () => {
describe('length', () => {
test('is not a number', () => {
expect(() => {
// $FlowFixMe: This type is incompatible with the expected param type of
diff('0', 0, isCommon, foundSubsequence);
diff(('0': any), 0, isCommon, foundSubsequence);
}).toThrow(/aLength/);
});
test('Infinity is not a safe integer', () => {
Expand Down Expand Up @@ -51,14 +50,12 @@ describe('invalid arg', () => {
describe('callback', () => {
test('null is not a function', () => {
expect(() => {
// $FlowFixMe: This type is incompatible with the expected param type of
diff(0, 0, null, foundSubsequence);
diff(0, 0, (null: any), foundSubsequence);
}).toThrow(/isCommon/);
});
test('undefined is not a function', () => {
expect(() => {
// $FlowFixMe: This type is incompatible with the expected param type of
diff(0, 0, isCommon, undefined);
diff(0, 0, isCommon, (undefined: any));
}).toThrow(/foundSubsequence/);
});
});
Expand Down