Skip to content

Improve description line when assertion fails: part 1 #5437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 4 commits into from
Feb 7, 2018
Merged

Improve description line when assertion fails: part 1 #5437

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4daca20
Improve description line when assertion fails: part 1
pedrottimark Feb 2, 2018
cc7a8a5
Replace conditional ands with default and destructuring
pedrottimark Feb 2, 2018
7548504
Replace using Object.is with Object.is equality
pedrottimark Feb 5, 2018
27c4f66
Update 1 more snapshot matchers test for jest-jasmine
pedrottimark Feb 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Replace conditional ands with default and destructuring
  • Loading branch information
@pedrottimark
pedrottimark committed Feb 2, 2018
commit cc7a8a5ff82d9926b77da63ffaf7d4d290b3e7eb
10 changes: 4 additions & 6 deletions packages/jest-matcher-utils/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,15 +150,13 @@ export const matcherHint = (
matcherName: string,
received: string = 'received',
expected: string = 'expected',
options: ?{
options: {
comment?: string,
isDirectExpectCall?: boolean,
secondArgument?: ?string,
},
} = {},
) => {
const comment = options && options.comment ? ` // ${options.comment}` : '';
const isDirectExpectCall = options && options.isDirectExpectCall;
const secondArgument = options && options.secondArgument;
const {comment, isDirectExpectCall, secondArgument} = options;
return (
chalk.dim('expect' + (isDirectExpectCall ? '' : '(')) +
RECEIVED_COLOR(received) +
Expand All @@ -167,6 +165,6 @@ export const matcherHint = (
(secondArgument
? `${chalk.dim(', ')}${EXPECTED_COLOR(secondArgument)}`
: '') +
chalk.dim(`)${comment}`)
chalk.dim(`)${comment ? ` // ${comment}` : ''}`)
);
};