Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Moving validate_cli_options from jest-util to jest-validate
  • Loading branch information
Aftabnack committed Feb 15, 2018
commit ba1366b8c04c49f07a50e6c9cf7f8dd18bb4c1c3
1 change: 1 addition & 0 deletions packages/jest-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
"jest-runtime": "^22.3.0",
"jest-snapshot": "^22.2.0",
"jest-util": "^22.3.0",
"jest-validate": "^22.3.0",
"jest-worker": "^22.2.2",
"micromatch": "^2.3.11",
"node-notifier": "^5.2.1",
Expand Down
8 changes: 2 additions & 6 deletions packages/jest-cli/src/cli/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,8 @@ import type {AggregatedResult} from 'types/TestResult';
import type {Argv} from 'types/Argv';
import type {GlobalConfig, Path, ProjectConfig} from 'types/Config';

import {
Console,
clearLine,
createDirectory,
validateCLIOptions,
} from 'jest-util';
import {Console, clearLine, createDirectory} from 'jest-util';
import {validateCLIOptions} from 'jest-validate';
import {readConfig} from 'jest-config';
import {version as VERSION} from '../../package.json';
import * as args from './args';
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-repl/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"main": "build/index.js",
"dependencies": {
"jest-runtime": "^22.3.0",
"jest-util": "^22.3.0",
"jest-validate": "^22.3.0",
"repl": "^0.1.3",
"yargs": "^10.0.3"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-repl/src/cli/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import path from 'path';

import Runtime from 'jest-runtime';
import yargs from 'yargs';
import {validateCLIOptions} from 'jest-util';
import {validateCLIOptions} from 'jest-validate';
import {version as VERSION} from '../../package.json';
import * as args from './args';

Expand Down
1 change: 1 addition & 0 deletions packages/jest-runtime/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"jest-regex-util": "^22.1.0",
"jest-resolve": "^22.3.0",
"jest-util": "^22.3.0",
"jest-validate": "^22.3.0",
"json-stable-stringify": "^1.0.1",
"micromatch": "^2.3.11",
"realpath-native": "^1.0.0",
Expand Down
3 changes: 2 additions & 1 deletion packages/jest-runtime/src/cli/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ import chalk from 'chalk';
import os from 'os';
import path from 'path';
import yargs from 'yargs';
import {Console, setGlobal, validateCLIOptions} from 'jest-util';
import {Console, setGlobal} from 'jest-util';
import {validateCLIOptions} from 'jest-validate';
import {readConfig} from 'jest-config';
// eslint-disable-next-line import/default
import Runtime from '../';
Expand Down
2 changes: 0 additions & 2 deletions packages/jest-util/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import installCommonGlobals from './install_common_globals';
import NullConsole from './null_console';
import isInteractive from './is_interative';
import setGlobal from './set_global';
import validateCLIOptions from './validate_cli_options';
import deepCyclicCopy from './deep_cyclic_copy';

const createDirectory = (path: string) => {
Expand All @@ -47,5 +46,4 @@ module.exports = {
installCommonGlobals,
isInteractive,
setGlobal,
validateCLIOptions,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically a breaking change. not sure if it matters, though

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It absolutely matters. Please see #5749

};
2 changes: 2 additions & 0 deletions packages/jest-validate/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,13 @@ import {
ValidationError,
} from './utils';
import validate from './validate';
import validateCLIOptions from './validate_cli_options';

module.exports = {
ValidationError,
createDidYouMeanMessage,
format,
logValidationWarning,
validate,
validateCLIOptions,
};
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@
import type {Argv} from 'types/Argv';

import chalk from 'chalk';
import {ValidationError, format, createDidYouMeanMessage} from 'jest-validate';
import {
createDidYouMeanMessage,
format,
logValidationWarning,
ValidationError,
} from './utils';

const BULLET: string = chalk.bold('\u25cf');

Expand Down