Skip to content

Issue #5197: Add descriptive error to Expect CalledWith methods when missing optional arguments #5547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjesun merged 5 commits into from
Feb 15, 2018
Merged

Issue #5197: Add descriptive error to Expect CalledWith methods when missing optional arguments #5547

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
79967be
Issue #5197: Add descriptive error when undefined is passed as unexpe…
jessecarfb Feb 13, 2018
ad77e02
Add test to verify error message for optional undefined arguments (sn…
jessecarfb Feb 14, 2018
0cf38d9
Fix test and update snapshot to meet expectations
jessecarfb Feb 14, 2018
5a4830d
Update changelog
jessecarfb Feb 14, 2018
b5118f0
Fix typo. Need more coffee
jessecarfb Feb 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Issue #5197: Add descriptive error when undefined is passed as unexpe… 
…cted argument
  • Loading branch information
@jessecarfb
jessecarfb committed Feb 14, 2018
commit 79967beae92d9364305a001d0dd8750de243ca1c
6 changes: 6 additions & 0 deletions packages/expect/src/spy_matchers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,14 @@ const formatMismatchedArgs = (expected, received) => {
` ${printExpected(expected[i])} as argument ${i + 1}, ` +
`but it was called with ${printReceived(received[i])}.`,
);
} else if (i >= expected.length) {
printedArgs.push(
` Did not expect argument ${i + 1} ` +
`but it was called with ${printReceived(received[i])}.`,
);
}
}

return printedArgs.join('\n');
};

Expand Down