Skip to content

Add error throwing to 'it'/'test' for incorrect arguments. #5558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 103 commits into from
Feb 26, 2018
Merged

Add error throwing to 'it'/'test' for incorrect arguments. #5558

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
103 commits
Select commit Hold shift + click to select a range
6e41bcd
feat: adds error when using it or test without proper arguments
brianlmacdonald Feb 12, 2018
b551940
fix: adds more descriptive error message
brianlmacdonald Feb 12, 2018
1de43af
feat: adds tests for errors
brianlmacdonald Feb 12, 2018
f4a012e
fix: removes bad test
brianlmacdonald Feb 12, 2018
a84007f
feat: adds tests for circus and jasmine2
brianlmacdonald Feb 13, 2018
85587bd
fix: small tweaks to test names
brianlmacdonald Feb 13, 2018
325fe11
fix: adds circus test to flow ignore
brianlmacdonald Feb 13, 2018
363e590
fix: variable names for circus it
brianlmacdonald Feb 13, 2018
bf07249
chore: updates changelog.
brianlmacdonald Feb 13, 2018
918ad6d
fixes: lint error
brianlmacdonald Feb 13, 2018
d2a3668
updates: globals tests and snapshots
brianlmacdonald Feb 13, 2018
b489b37
fix: resets snapshot file
brianlmacdonald Feb 13, 2018
a873a75
fix: temp skips failing tests until further direction
brianlmacdonald Feb 13, 2018
119130c
feat: adds tests for test alias
brianlmacdonald Feb 13, 2018
1d6e12c
fix: renamed unimplemented test. Comments out rest snapshot for now.
brianlmacdonald Feb 14, 2018
29a0f0a
fix: restores rest snapshot and removes abs path from snapshot stack
brianlmacdonald Feb 15, 2018
d8eac51
fix: cleans up stack using cleanUpStackTrace
brianlmacdonald Feb 15, 2018
e09303f
fix: modifies regex in utils
brianlmacdonald Feb 15, 2018
5106800
fix: reverts utils regex
brianlmacdonald Feb 15, 2018
84d9a9b
fix: reverts line deletion in utils.
brianlmacdonald Feb 15, 2018
7815602
fix: replaces env in cleanup stack trace
brianlmacdonald Feb 15, 2018
0728d30
fix: updates utils to current version
brianlmacdonald Feb 15, 2018
b10ad04
fix: updates master
brianlmacdonald Feb 16, 2018
1ba971c
Merge remote-tracking branch 'upstream/master'
brianlmacdonald Feb 20, 2018
19d8d88
feat: adds error when using it or test without proper arguments
brianlmacdonald Feb 12, 2018
af8efd7
fix: adds more descriptive error message
brianlmacdonald Feb 12, 2018
30ccac2
feat: adds tests for errors
brianlmacdonald Feb 12, 2018
1842a5d
fix: removes bad test
brianlmacdonald Feb 12, 2018
17d3050
feat: adds tests for circus and jasmine2
brianlmacdonald Feb 13, 2018
754bf38
fix: small tweaks to test names
brianlmacdonald Feb 13, 2018
5464098
fix: adds circus test to flow ignore
brianlmacdonald Feb 13, 2018
42ef481
fix: variable names for circus it
brianlmacdonald Feb 13, 2018
fdc0dc3
chore: updates changelog.
brianlmacdonald Feb 13, 2018
e986609
updates: globals tests and snapshots
brianlmacdonald Feb 13, 2018
a6ab7b0
fix: resets snapshot file
brianlmacdonald Feb 13, 2018
5453e9f
fix: temp skips failing tests until further direction
brianlmacdonald Feb 13, 2018
1520b94
feat: adds tests for test alias
brianlmacdonald Feb 13, 2018
193cdf6
fix: renamed unimplemented test. Comments out rest snapshot for now.
brianlmacdonald Feb 14, 2018
b2ac1c5
fix: restores rest snapshot and removes abs path from snapshot stack
brianlmacdonald Feb 15, 2018
5ad1768
fix: cleans up stack using cleanUpStackTrace
brianlmacdonald Feb 15, 2018
0312138
fix: modifies regex in utils
brianlmacdonald Feb 15, 2018
ca714e7
fix: reverts utils regex
brianlmacdonald Feb 15, 2018
1a4dd3a
fix: reverts line deletion in utils.
brianlmacdonald Feb 15, 2018
a1ea320
fix: replaces env in cleanup stack trace
brianlmacdonald Feb 15, 2018
ef31915
fix: addresses patch
brianlmacdonald Feb 20, 2018
5e0aabd
fix: replaces overly long packages path for CI test
brianlmacdonald Feb 20, 2018
30aa554
fix: adds new snapshot after packages fix
brianlmacdonald Feb 20, 2018
735bbc2
fix: updates globals snapshot after packages fix
brianlmacdonald Feb 20, 2018
9514c32
fix: finalizes globals snapshot
brianlmacdonald Feb 20, 2018
edc9231
fix: reverses bad snapshot commit
brianlmacdonald Feb 20, 2018
d5aa613
fix: adds missing cli snapshot
brianlmacdonald Feb 20, 2018
0a560ed
fix: bad snap commit
brianlmacdonald Feb 20, 2018
911c6e1
fix: format test name bad commit
brianlmacdonald Feb 20, 2018
07a51fb
fix: adds back trailing newline
brianlmacdonald Feb 20, 2018
281100c
Merge remote-tracking branch 'upstream/master'
brianlmacdonald Feb 21, 2018
ca02d0a
updates master
brianlmacdonald Feb 22, 2018
6e351e7
feat: adds error when using it or test without proper arguments
brianlmacdonald Feb 12, 2018
7eca76f
fix: adds more descriptive error message
brianlmacdonald Feb 12, 2018
f85f956
feat: adds tests for errors
brianlmacdonald Feb 12, 2018
e64357e
fix: removes bad test
brianlmacdonald Feb 12, 2018
f2359e0
feat: adds tests for circus and jasmine2
brianlmacdonald Feb 13, 2018
4aa3101
fix: small tweaks to test names
brianlmacdonald Feb 13, 2018
139973b
fix: adds circus test to flow ignore
brianlmacdonald Feb 13, 2018
c0c478e
fix: variable names for circus it
brianlmacdonald Feb 13, 2018
ba03582
chore: updates changelog.
brianlmacdonald Feb 13, 2018
061dab3
updates: globals tests and snapshots
brianlmacdonald Feb 13, 2018
7195e05
fix: resets snapshot file
brianlmacdonald Feb 13, 2018
e411607
fix: temp skips failing tests until further direction
brianlmacdonald Feb 13, 2018
5163ee3
feat: adds tests for test alias
brianlmacdonald Feb 13, 2018
e0ff615
fix: renamed unimplemented test. Comments out rest snapshot for now.
brianlmacdonald Feb 14, 2018
29a3d64
fix: restores rest snapshot and removes abs path from snapshot stack
brianlmacdonald Feb 15, 2018
85f359e
fix: cleans up stack using cleanUpStackTrace
brianlmacdonald Feb 15, 2018
426cb07
fix: modifies regex in utils
brianlmacdonald Feb 15, 2018
895f57e
fix: reverts utils regex
brianlmacdonald Feb 15, 2018
e6f8d6a
fix: reverts line deletion in utils.
brianlmacdonald Feb 15, 2018
4547c55
fix: replaces env in cleanup stack trace
brianlmacdonald Feb 15, 2018
5c1d541
fix: resolves rebase conflict
brianlmacdonald Feb 21, 2018
dd36839
feat: adds tests for errors
brianlmacdonald Feb 12, 2018
873671a
fix: removes bad test
brianlmacdonald Feb 12, 2018
b36f4fb
fix: rebase conflict resolved
brianlmacdonald Feb 21, 2018
07154b3
fix: variable names for circus it
brianlmacdonald Feb 13, 2018
2b664de
fix: temp skips failing tests until further direction
brianlmacdonald Feb 13, 2018
17d2f77
feat: adds tests for test alias
brianlmacdonald Feb 13, 2018
b867548
fix: renamed unimplemented test. Comments out rest snapshot for now.
brianlmacdonald Feb 14, 2018
b27c0b5
fix: restores rest snapshot and removes abs path from snapshot stack
brianlmacdonald Feb 15, 2018
58e973b
fix: cleans up stack using cleanUpStackTrace
brianlmacdonald Feb 15, 2018
f1df10b
fix: modifies regex in utils
brianlmacdonald Feb 15, 2018
7648643
fix: reverts utils regex
brianlmacdonald Feb 15, 2018
c612bca
fix: reverts line deletion in utils.
brianlmacdonald Feb 15, 2018
feaaf58
fix: replaces env in cleanup stack trace
brianlmacdonald Feb 15, 2018
7378e67
fix: addresses patch
brianlmacdonald Feb 20, 2018
6e2d789
fix: replaces overly long packages path for CI test
brianlmacdonald Feb 20, 2018
bf4e287
fix: adds new snapshot after packages fix
brianlmacdonald Feb 20, 2018
ba0c286
fix: updates globals snapshot after packages fix
brianlmacdonald Feb 20, 2018
8e746b4
fix: reverses bad snapshot commit
brianlmacdonald Feb 20, 2018
f92e725
fix: adds missing cli snapshot
brianlmacdonald Feb 20, 2018
7ab85b1
fix: format test name bad commit
brianlmacdonald Feb 20, 2018
c1753b3
fix: adds back trailing newline
brianlmacdonald Feb 20, 2018
b5985e1
fix: removes redundant BUILD path. updates snapshots
brianlmacdonald Feb 22, 2018
e03c1a7
fix: resolves remote changes
brianlmacdonald Feb 22, 2018
06875a8
fix: deletes empty file, updates changelog
brianlmacdonald Feb 23, 2018
661496b
Merge branch 'master' into feat/iterrorthrowing
brianlmacdonald Feb 23, 2018
f3f1213
fix: handle flow ignores in circus tests
thymikee Feb 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: adds circus test to flow ignore
  • Loading branch information
@brianlmacdonald
brianlmacdonald committed Feb 20, 2018
commit 5464098790119b21f65d4632a384b782285caa76
1 change: 1 addition & 0 deletions .flowconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
[ignore]
.*/examples/.*
.*/node_modules/metro-bundler/.*
.*/circus_it_test_error.test.js*.
Copy link
Contributor

@thymikee thymikee Feb 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, this is not supposed to be here

Copy link
Contributor Author

@brianlmacdonald brianlmacdonald Feb 23, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thymikee it's so the jest-circus tests can check the error for a missing or incorrect argument. If Flow is on for this file it won't run the test. I'm happy to go about this in another manner, if you'd rather.

Copy link
Contributor

@thymikee thymikee Feb 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the @flow pragma from circus test. Let's keep this config as clean as possible

Copy link
Contributor Author

@brianlmacdonald brianlmacdonald Feb 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thymikee

        'integration-tests/__tests__/**/*',
        'packages/babel-jest/**/*.test.js',
        'packages/babel-plugin-jest-hoist/**/*.test.js',
        'packages/babel-preset-jest/**/*.test.js',
        'packages/eslint-config-fb-strict/**/*.test.js',
        'packages/eslint-plugin-jest/**/*.test.js',
        'packages/jest-changed-files/**/*.test.js',
       ===> 'packages/jest-circus/**/*.test.js',<====
        'packages/jest-diff/**/*.test.js',
        'packages/jest-docblock/**/*.test.js',
        'packages/jest-editor-support/**/*.test.js',
        'packages/jest/**/*.test.js',
        'packages/pretty-format/**/*.test.js',
      ],
      rules: {
        'flowtype/require-valid-file-annotation': [2, 'always'],
      },

The lint config throws an error during yarn test. Can I remove this line? Or add the test file to the lint ignore? Or an exception to the rule?

Copy link
Contributor

@thymikee thymikee Feb 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. The problem with this and previous approach is that it's easy to forget we have this "exception", which may lead to falsy feel of confidence about our codebase. I've pushed a commit with a proper, in my opinion, change for this case 🙂

Copy link
Contributor Author

@brianlmacdonald brianlmacdonald Feb 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! $FlowFixMe: is something I'll have to remember. Thanks!


[options]
module.name_mapper='^pretty-format$' -> '<PROJECT_ROOT>/packages/pretty-format/src/index.js'
Expand Down
4 changes: 2 additions & 2 deletions packages/jest-circus/src/__tests__/circus_it_test_error.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
/**
* Copyright (c) 2014-present, Facebook, Inc. All rights reserved.
* Copyright (c) 2015-present, Facebook, Inc. All rights reserved.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow
* *@flow
*/

'use strict';
Expand Down