Skip to content

[WIP] Remove usage of retainLines #5594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 19 commits into from
Feb 21, 2018
Merged

[WIP] Remove usage of retainLines #5594

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
2b8e256
Remove usage of `retainLines`
SimenB Feb 17, 2018
0c1dd5c
update changelog
SimenB Feb 17, 2018
8f9e54f
Move callsite to jest-util, add sourcemap support
rickhanlonii Feb 17, 2018
ab81892
This is a type
rickhanlonii Feb 17, 2018
1189fe7
Merge remote-tracking branch 'upstream/master' into remove-retainlines
rickhanlonii Feb 17, 2018
8e50d0f
Remove unused function moved to jest-util
rickhanlonii Feb 17, 2018
6ad7202
Fix lint
rickhanlonii Feb 17, 2018
6ec7b74
Minor clean `up
rickhanlonii Feb 17, 2018
11948b8
Feedback updates
rickhanlonii Feb 17, 2018
765f78a
fix flow violations and minimize diff
SimenB Feb 18, 2018
f0c6e08
add todo
SimenB Feb 18, 2018
d4b0600
Merge branch 'master' into remove-retainlines
SimenB Feb 19, 2018
7ce154d
use sourcemaps in buffered console as well
SimenB Feb 19, 2018
3f2ccb8
fix stupid typo
SimenB Feb 19, 2018
e73423d
Add unit tests for get_callsite
rickhanlonii Feb 20, 2018
0a29175
Fix tests
rickhanlonii Feb 20, 2018
e7ccbc6
Merge remote-tracking branch 'upstream/master' into remove-retainlines
rickhanlonii Feb 20, 2018
2e0e0a3
Merge branch 'master' into remove-retainlines
SimenB Feb 21, 2018
736eb2b
move changelog entry
SimenB Feb 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add todo
  • Loading branch information
@SimenB
SimenB committed Feb 18, 2018
commit f0c6e08aa8b49e963fe64019f87b69d4188c3c75
1 change: 1 addition & 0 deletions packages/jest-runner/src/run_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ async function runTestInternal(
} else if (globalConfig.verbose) {
testConsole = new Console(consoleOut, process.stderr, consoleFormatter);
} else {
// TODO: Should `BufferedConsole` receive `consoleFormatter` as well?
Copy link
Member Author

@SimenB SimenB Feb 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii I think so - the internal _log call in BufferedConsole is without sourcemaps now

testConsole = new BufferedConsole();
}

Expand Down