Skip to content

Generating coverage for files passed in --findRelatedTests, --onlyChanged and --watch scenarios #5601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 25 commits into from
Mar 21, 2018
Merged

Generating coverage for files passed in --findRelatedTests, --onlyChanged and --watch scenarios #5601

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
b45fd58
Jump start using the work from #4246
stipsan Feb 17, 2018
0a39903
checking how it looks without an extra flag
stipsan Feb 17, 2018
055177c
makes more sense to colocate the test here
stipsan Feb 17, 2018
e1472a3
remove mystery files
stipsan Feb 17, 2018
8f073bc
remove references to the flag
stipsan Feb 17, 2018
61937f5
update docs
stipsan Feb 18, 2018
b253210
add test case for --onlyChanged and --coverage
stipsan Feb 18, 2018
812e46f
update snapshot to what it should be
stipsan Feb 18, 2018
5b82b34
apply collectCoverageFrom patterns after finding tests
stipsan Feb 18, 2018
139ed5a
Collect possible coverage patterns while searching for tests
stipsan Feb 18, 2018
63243a5
improve test results
stipsan Feb 18, 2018
a5891db
hi there flow
stipsan Feb 18, 2018
a61c7dd
skip on windows
stipsan Feb 18, 2018
7556f02
will the windows build pass this time?
stipsan Feb 18, 2018
644efaf
fix test on windows
SimenB Feb 18, 2018
26b919b
remove underscore as it's no longer a private api
stipsan Feb 18, 2018
1e46f07
polymorphing
stipsan Feb 18, 2018
cddc4bd
simplify test
stipsan Feb 18, 2018
1b8e4be
increase test coverage in jest-config/normalize
stipsan Feb 22, 2018
0cbaf3a
make the linter happy again
stipsan Feb 22, 2018
0e234b6
should use argv as it's not a config option
stipsan Feb 22, 2018
35f367b
test coverage for run_jest
stipsan Mar 18, 2018
7e92015
update snapshots
stipsan Mar 18, 2018
988081b
remove object spread, replaced with Object.assign
stipsan Mar 18, 2018
7d83ec8
add changelog entry
stipsan Mar 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve test results
  • Loading branch information
@stipsan
stipsan committed Mar 17, 2018
commit 63243a56bfcf626513ea250be4a9b7297f7ea6f8
6 changes: 5 additions & 1 deletion integration-tests/__tests__/only_changed.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,11 @@ test('report test coverage for only changed files', () => {
'a.js': 'module.exports = {}',
'b.js': 'module.exports = {}',
'package.json': JSON.stringify({
jest: {collectCoverage: true, testEnvironment: 'node'},
jest: {
collectCoverage: true,
coverageReporters: ['text'],
testEnvironment: 'node',
},
}),
});

Expand Down
1 change: 1 addition & 0 deletions packages/jest-config/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import readConfigFileAndSetRootDir from './read_config_file_and_set_root_dir';
export {getTestEnvironment, isJSONString} from './utils';
export {default as normalize} from './normalize';
export {default as deprecationEntries} from './deprecated';
export {_replaceRootDirInPath} from './utils';
Copy link
Contributor

@thymikee thymikee Feb 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be renamed to replaceRootDirInPath, as underscore implies "private" method, which it's not now :D

Copy link
Contributor Author

@stipsan stipsan Feb 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right 😄


export function readConfig(
argv: Argv,
Expand Down