Skip to content

fix: make Errors match with ordinary objects (fixes #5359) #5611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 3 commits into from
Feb 19, 2018
Merged

fix: make Errors match with ordinary objects (fixes #5359) #5611

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47c0b7e
fix: make Errors match with ordinary objects (#5359)
kpsroka Feb 19, 2018
7032900
Merge remote-tracking branch 'upstream/master'
kpsroka Feb 19, 2018
f0b2505
chore: updating CHANGELOG.md
kpsroka Feb 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: updating CHANGELOG.md
  • Loading branch information
@kpsroka
kpsroka committed Feb 19, 2018
commit f0b2505dc7d125eeaa3ae7df97d4f74ba719d313
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

### Fixes

* `[enzyme]` Allow matching of Errors against plain objects
Copy link
Member

@SimenB SimenB Feb 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not enzyme, wrong matcher library :D

Copy link
Contributor

@thymikee thymikee Feb 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5614

Copy link
Member

@SimenB SimenB Feb 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, nice!

([#5611](https://github.com/facebook/jest/pull/5611))
* `[jest-cli]` Don't skip matchers for exact files
([#5582](https://github.com/facebook/jest/pull/5582))
* `[docs]` Update discord links
Expand Down