Skip to content

[WIP] Make toThrow matcher pass only if Error-like object is returned from promises #5670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 11 commits into from
Mar 2, 2018
Merged

[WIP] Make toThrow matcher pass only if Error-like object is returned from promises #5670

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1cca08b
Fix rejects.not matcher
peterdanis Feb 24, 2018
fa762c8
Check if resolved/rejected value is Error instance
peterdanis Feb 26, 2018
b34fc0a
Add test
peterdanis Feb 26, 2018
277f310
Changelog
peterdanis Feb 26, 2018
756d867
Change instanceof check
peterdanis Feb 27, 2018
f3aecbe
Add additional tests & update snaps
peterdanis Feb 27, 2018
ce8e83f
Add isError fn
peterdanis Mar 1, 2018
f72840a
Change err msg to also test partial string match
peterdanis Mar 1, 2018
b4c519e
Move isError to expect utils
peterdanis Mar 1, 2018
294d25e
Add isError test
peterdanis Mar 1, 2018
91b91a4
Update changelog
peterdanis Mar 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changelog
  • Loading branch information
@peterdanis
peterdanis committed Mar 1, 2018
commit 277f310687bfe8c1b70d4646ff02c650fd660936
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
errors to `it`/ `test` for invalid arguements.
* `[jest-matcher-utils]` Add `isNot` option to `matcherHint` function
([#5512](https://github.com/facebook/jest/pull/5512))
* `[expect]` Make toThrow matcher pass only if Error object is returned from
promises ([#5670](https://github.com/facebook/jest/pull/5670))

### Fixes

Expand All @@ -20,6 +22,8 @@
([#5692](https://github.com/facebook/jest/pull/5692))
* `[jest-cli]` Fix update snapshot issue when using watchAll
([#5696](https://github.com/facebook/jest/pull/5696))
* `[expect]` Fix rejects.not matcher
([#5670](https://github.com/facebook/jest/pull/5670))

## 22.4.2

Expand Down