Skip to content

Interactive Snapshot Mode improvements #5864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 13 commits into from
Mar 26, 2018
Merged

Interactive Snapshot Mode improvements #5864

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1825ed4
Interactive Snapshot Mode updates
rickhanlonii Mar 25, 2018
2ac970b
Update docs
rickhanlonii Mar 25, 2018
f6c9ead
Squash images
rickhanlonii Mar 25, 2018
9ce3f4b
More squashing
rickhanlonii Mar 25, 2018
733c032
Update snaps
rickhanlonii Mar 25, 2018
6fb9184
Move arrow to a const
rickhanlonii Mar 25, 2018
7a6cd1b
Add comment
rickhanlonii Mar 25, 2018
7537f58
Update GIF
rickhanlonii Mar 25, 2018
170f708
Clarify cursorUp usage
rickhanlonii Mar 25, 2018
d525507
Update snaps
rickhanlonii Mar 25, 2018
daa8fcc
Update CHANGELOG
rickhanlonii Mar 25, 2018
2eb3a44
Merge remote-tracking branch 'upstream/master' into rh-interactive-im…
rickhanlonii Mar 25, 2018
d66a2b8
Add AssertionLocation type
rickhanlonii Mar 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move arrow to a const
  • Loading branch information
@rickhanlonii
rickhanlonii committed Mar 25, 2018
commit 6fb918473c54fc42fa534ff968e2fd031a31b745
2 changes: 1 addition & 1 deletion packages/jest-cli/src/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
const isWindows = process.platform === 'win32';

export const CLEAR = isWindows ? '\x1B[2J\x1B[0f' : '\x1B[2J\x1B[3J\x1B[H';

export const ARROW = ' \u203A ';
export const KEYS = {
A: '61',
ARROW_DOWN: '1b5b42',
Expand Down
22 changes: 11 additions & 11 deletions packages/jest-cli/src/snapshot_interactive_mode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import type {AggregatedResult} from 'types/TestResult';
const chalk = require('chalk');
const ansiEscapes = require('ansi-escapes');
const {pluralize} = require('./reporters/utils');
const {KEYS} = require('./constants');
const {KEYS, ARROW} = require('./constants');

export default class SnapshotInteractiveMode {
_pipe: stream$Writable | tty$WriteStream;
Expand Down Expand Up @@ -58,22 +58,22 @@ export default class SnapshotInteractiveMode {
}
const messages = [
'\n' + chalk.bold('Interactive Snapshot Progress'),
' \u203A ' + stats,
ARROW + stats,
'\n' + chalk.bold('Watch Usage'),

chalk.dim(' \u203A Press ') +
chalk.dim(ARROW + 'Press ') +
'u' +
chalk.dim(' to update failing snapshots for this test.'),

chalk.dim(' \u203A Press ') +
chalk.dim(ARROW + 'Press ') +
's' +
chalk.dim(' to skip the current test.'),

chalk.dim(' \u203A Press ') +
chalk.dim(ARROW + 'Press ') +
'q' +
chalk.dim(' to quit Interactive Snapshot Mode.'),

chalk.dim(' \u203A Press ') +
chalk.dim(ARROW + 'Press ') +
'Enter' +
chalk.dim(' to trigger a test run.'),
];
Expand All @@ -99,14 +99,14 @@ export default class SnapshotInteractiveMode {
}
const messages = [
'\n' + chalk.bold('Interactive Snapshot Result'),
' \u203A ' + stats,
ARROW + stats,
'\n' + chalk.bold('Watch Usage'),

chalk.dim(' \u203A Press ') +
chalk.dim(ARROW + 'Press ') +
'r' +
chalk.dim(' to restart Interactive Snapshot Mode.'),

chalk.dim(' \u203A Press ') +
chalk.dim(ARROW + 'Press ') +
'q' +
chalk.dim(' to quit Interactive Snapshot Mode.'),
];
Expand All @@ -127,10 +127,10 @@ export default class SnapshotInteractiveMode {
}
const messages = [
'\n' + chalk.bold('Interactive Snapshot Result'),
' \u203A ' + stats,
ARROW + stats,
'\n' + chalk.bold('Watch Usage'),

chalk.dim(' \u203A Press ') +
chalk.dim(ARROW + 'Press ') +
'Enter' +
chalk.dim(' to return to watch mode.'),
];
Expand Down