Skip to content

Move Options.coverage to ProjectWorkspace.collectCoverage #5929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orta merged 6 commits into from
Apr 9, 2018
Merged

Move Options.coverage to ProjectWorkspace.collectCoverage #5929

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
805a69c
update type definitions
stephtr Apr 5, 2018
73a8a72
Merge branch 'master' of https://github.com/facebook/jest into covera…
stephtr Apr 5, 2018
c8c16cc
Move `Options.coverage` to `ProjectWorkspace.collectCoverage`
stephtr Apr 5, 2018
cdcd22c
mark collectCoverage as optional
stephtr Apr 5, 2018
3b71e7e
fix failing test
stephtr Apr 5, 2018
9d81de7
update changelog
stephtr Apr 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix failing test
  • Loading branch information
@stephtr
stephtr committed Apr 5, 2018
commit 3b71e7e213b7004081ad4d44814854aebaec388e
4 changes: 2 additions & 2 deletions packages/jest-editor-support/src/__tests__/runner.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ describe('Runner', () => {
it('calls createProcess with the --coverage arg when provided', () => {
const expected = '--coverage';

const workspace: any = { collectCoverage: true };
const workspace: any = {collectCoverage: true};
const options = {};
const sut = new Runner(workspace, options);
sut.start(false);
Expand All @@ -196,7 +196,7 @@ describe('Runner', () => {
it('calls createProcess with the ---no-coverage arg when provided and false', () => {
const expected = '--no-coverage';

const workspace: any = { collectCoverage: false };
const workspace: any = {collectCoverage: false};
const options = {};
const sut = new Runner(workspace, options);
sut.start(false);
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-editor-support/src/project_workspace.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export default class ProjectWorkspace {

/**
* Whether test coverage should be (automatically) collected.
*
*
* @type {boolean}
*/
collectCoverage: ?boolean;
Expand Down