Skip to content

Inject deprecationEntries from jest-config to jest-validate. #6067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 7 commits into from
Apr 28, 2018
Merged

Inject deprecationEntries from jest-config to jest-validate. #6067

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
61e95ee
Move `deprecationEntries` from `jest-config` to `jest-validate`.
Apr 25, 2018
37c4988
Update CHANGELOG.md
Apr 25, 2018
304da8b
Update .gitignore
Apr 25, 2018
1020177
deprecations are an option
Apr 26, 2018
feadbe7
Fix changelog
Apr 26, 2018
acb5231
Update CHANGELOG.md
Apr 26, 2018
1856c01
Properly describe changes on changelog.md
Apr 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update CHANGELOG.md
  • Loading branch information
Sid Ferreira authored Apr 26, 2018
commit acb52315770ad0abc074fdded8031f8277b2fba7
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

### Features

* `[jest-config]` According to #5828, moves `deprecationEntries` from
* `[jest-config]` According to ([#5828](https://github.com/facebook/jest/issues/5828)), moves `deprecationEntries` from
Copy link
Member

@SimenB SimenB Apr 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not moved, it's injected now. mind fixing?

Copy link
Author

@sidferreira sidferreira Apr 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed

`jest-config` to `jest-validate`.
([#6067](https://github.com/facebook/jest/pull/6067))
* `[jest-validate]` According to #5828, moves `deprecationEntries` from
* `[jest-validate]` According to ([#5828](https://github.com/facebook/jest/issues/5828)), moves `deprecationEntries` from
Copy link
Contributor

@thymikee thymikee Apr 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing actually changed in jest-config so we should remove that mention. How about rephrasing it to be more descriptive to regular reader:

[jest-validate] Get rid of `jest-config` dependency

Copy link
Author

@sidferreira sidferreira Apr 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed

Copy link
Member

@SimenB SimenB Apr 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, I don't think we need to link to #5828 at all, linking to this PR is enough (then peaople can follow the trail if they are curious)

Copy link
Author

@sidferreira sidferreira Apr 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

`jest-config` to `jest-validate`.
Copy link
Member

@rickhanlonii rickhanlonii Apr 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line duplicated?

Copy link
Member

@rickhanlonii rickhanlonii Apr 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be helpful to link to #5828 (though I'm not sure it's necessary to mention)

Copy link
Author

@sidferreira sidferreira Apr 26, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii Well, there are mentions to two packages. As I wasn't sure if this would be used to an auto-generated doc, I duplicated just like

[expect] Add stack trace for async errors (#6008)
[jest-jasmine2] Add stack trace for timeouts (#6008)

few lines below

Copy link
Member

@rickhanlonii rickhanlonii Apr 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I should read closer, thanks!

Copy link
Author

@sidferreira sidferreira Apr 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, and thanks for checking it out!

([#6067](https://github.com/facebook/jest/pull/6067))
* `[jest-runtime]` Fix typo.
Copy link
Member

@SimenB SimenB Apr 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is included, it should be under chores. but don't think a typo fix needs to be in the changelog, especially as it's not user visible (the typo wasn't in a message show to the user.)

Copy link
Author

@sidferreira sidferreira Apr 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just removed it! 😁

Expand Down