[jest-editor-support] update definition#6212
Merged
orta merged 1 commit intojestjs:masterfrom May 20, 2018
stephtr:patch-1
Merged
[jest-editor-support] update definition#6212orta merged 1 commit intojestjs:masterfrom stephtr:patch-1
orta merged 1 commit intojestjs:masterfrom
stephtr:patch-1
Conversation
According to (the implementation)[https://github.com/facebook/jest/blob/f4f51914d577dc53748f599f3f626dfe3154883e/packages/jest-editor-support/src/Snapshot.js#L106] the first parameter of Snapshot constructor is optional.
Codecov Report
@@ Coverage Diff @@
## master #6212 +/- ##
=======================================
Coverage 64.37% 64.37%
=======================================
Files 219 219
Lines 8453 8453
Branches 4 4
=======================================
Hits 5442 5442
Misses 3010 3010
Partials 1 1Continue to review full report at Codecov.
|
Member
|
@orta thoughts? I think it makes sense, but what do I know? 😀 |
Member
|
Yeah, look like it handles undefined correctly 👍 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the implementation the first parameter of Snapshot constructor is optional.
#trivial