-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Add each to jest-cirucs #6309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add each to jest-cirucs #6309
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
17546bf
Add flowtypes to jest-each entrypoint
mattphillips fe973ab
Add jest-each dependency to jest-circus
mattphillips 3bb5231
Add each circus test and describe
mattphillips 3d5e4ca
Update broken snapshot
mattphillips eb43bb3
Add describe only and skip tests
mattphillips 6bbd790
Add changelog entry
mattphillips c773fe1
Fix lint warning
mattphillips 464ce7d
Move failing describe.each test to bottom of file
mattphillips ace0d06
Merge branch 'master' into jest-circus
SimenB 2883ba0
Update jest-each entry types to Array<mixed>
mattphillips 4861776
Merge branch 'master' into jest-circus
thymikee 4d21e8b
Update changelog
mattphillips c4fcf55
Merge branch 'master' into jest-circus
mattphillips 1a0213d
Update docs to point to node util format
mattphillips File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add describe only and skip tests
- Loading branch information
commit eb43bb3a27e5b2185d37ff5cd4714d28907e517b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /** | ||
| * Copyright (c) 2018-present, Facebook, Inc. All rights reserved. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| describe.only.each([[true, true], [true, true]])( | ||
| 'passes all rows expected %s == %s', | ||
| (left, right) => { | ||
| it('passes', () => { | ||
| expect(left).toBe(right); | ||
| }); | ||
| } | ||
| ); | ||
|
|
||
| // This failing tests should never because of the above `only` so the suite | ||
| // should pass | ||
| describe.each([[false, true]])( | ||
| 'fails all rows expected %s == %s', | ||
| (left, right) => { | ||
| it('fails', () => { | ||
| expect(left).toBe(right); | ||
| }); | ||
| } | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, do we need skipping it on windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we tried removing this before and it failed 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #6102 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably add a helper fixing the differing symbols on windows and unix so that the integration tests can run. separate issue, though