Skip to content

Improve the message when run coverage while there are no tests #6334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 13 commits into from
Aug 9, 2018
Merged

Improve the message when run coverage while there are no tests #6334

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f238bec
Improve the message when running coverage while there are no tests
May 29, 2018
94f2331
use Object.assign
May 29, 2018
71b829e
Only mock specific functions exported by istanbul-lib-coverage
May 29, 2018
271b542
Add e2e tests for coverage threshold.
May 30, 2018
c4e749b
Merge branch 'master' into coverage-no-tests-warning
rhysawilliams2010 May 30, 2018
f4b160b
revert unnecessary test changes
May 30, 2018
bf81a29
linting
May 30, 2018
b62e3df
Replace process.cwd() in stderr snapshot test.
May 31, 2018
3c36107
Merge branch 'master' of https://github.com/facebook/jest into covera…
May 31, 2018
68a822b
Make the tests more robust by using extractSummary method to compare
May 31, 2018
f671f8e
Merge remote-tracking branch 'upstream/master' into pr/6334
thymikee Aug 8, 2018
66798eb
move changelog entry
thymikee Aug 8, 2018
c8b2189
Merge branch 'master' into coverage-no-tests-warning
thymikee Aug 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use Object.assign
  • Loading branch information
rhys williams committed May 29, 2018
commit 94f2331c6e8e8eef1e10376ed3f81935ea106fc1
6 changes: 2 additions & 4 deletions packages/jest-cli/src/reporters/__tests__/coverage_reporter.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,8 @@ describe('onRunComplete', () => {
].reduce((c, f) => {
const file = path.resolve(f[0]);
const override = f[1];
c[file] = new CoverageSummary({
...covSummary,
...override,
});
const obj = Object.assign({}, covSummary, override);
c[file] = new CoverageSummary(obj);
return c;
}, {});

Expand Down