Skip to content

Fix wrong messages for nthCalledWith #6340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 5 commits into from
May 30, 2018
Merged

Fix wrong messages for nthCalledWith #6340

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1688d70
Fix wrong messages for nthCalledWith
chinesedfan May 29, 2018
e82cc10
Update the test snapshot
chinesedfan May 29, 2018
320a3cd
Add changes to CHANGELOG.md
chinesedfan May 29, 2018
d9c950f
Update PR number
chinesedfan May 30, 2018
ce00470
Merge branch 'master' into patch-1
cpojer May 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix wrong messages for nthCalledWith
  • Loading branch information
@chinesedfan
chinesedfan committed May 29, 2018
commit 1688d706b9df36ff63fbdff56aab71b6ed63008e
6 changes: 5 additions & 1 deletion packages/expect/src/spy_matchers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,11 @@ const createNthCalledWithMatcher = (matcherName: string) => (
`Expected ${identifier} ${nthToString(
nth,
)} call to have been called with:\n` +
formatMismatchedCalls(calls, expected, LAST_CALL_PRINT_LIMIT);
formatMismatchedCalls(
calls[nth - 1] ? [calls[nth - 1]] : [],
expected,
LAST_CALL_PRINT_LIMIT,
);

return {message, pass};
};
Expand Down