Skip to content

[babel-plugin-jest-hoist] Fix MockNativeMethods access in react-native #6505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 6 commits into from
Jun 20, 2018
Merged

[babel-plugin-jest-hoist] Fix MockNativeMethods access in react-native #6505

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
02361c7
Fix MockNativeMethods access in react-native
timwangdev Jun 20, 2018
29a6bf0
Update changelog and RegExp
Jun 20, 2018
afaf802
Update error message
Jun 20, 2018
f6f29c2
Update CHANGELOG.md
SimenB Jun 20, 2018
5e816ff
Reverted code format
Jun 20, 2018
366cb5b
Add mock variable name test
Jun 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix MockNativeMethods access in react-native
  • Loading branch information
@timwangdev
timwangdev authored Jun 20, 2018
commit 02361c753f4e08b5c7a667027b1dfe90db0fdb07
2 changes: 1 addition & 1 deletion packages/babel-plugin-jest-hoist/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ FUNCTIONS.mock = args => {
if (!found) {
invariant(
(scope.hasGlobal(name) && WHITELISTED_IDENTIFIERS[name]) ||
/^mock/.test(name) ||
/^[Mm]ock/.test(name) ||
Copy link
Member

@SimenB SimenB Jun 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/^mock/i? MOCK_THING should be fine as well, IMO.

Copy link
Member

@SimenB SimenB Jun 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also update the message on line 126

Copy link
Contributor Author

@timwangdev timwangdev Jun 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

// Allow istanbul's coverage variable to pass.
/^(?:__)?cov/.test(name),
'The module factory of `jest.mock()` is not allowed to ' +
Expand Down