Skip to content

Fix reporters' config #6542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boujeepossum merged 7 commits into from
Aug 16, 2018
Merged

Fix reporters' config #6542

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
257cc2f
Fix `reporters` to handle string params
artola Jun 25, 2018
bd778fb
Update CHANGELOG.md
artola Jun 25, 2018
23730f4
Update Config.js
artola Jun 25, 2018
09c3105
prettier code
artola Jun 25, 2018
8b3c2d0
prettier code
artola Jun 25, 2018
5ebd1ce
regression test
artola Jun 25, 2018
8cb41d3
Update CHANGELOG.md
artola Jun 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix reporters to handle string params 
Documentation shows reporters as `reporters [array<moduleName | [moduleName, options]>]`, the code was incorrectly handling the following cases:

```
// no `string` moduleName
// _addCustomReporters(reporters: Array<ReporterConfig>)
reporters: ['default', 'someother']

// _shouldAddDefaultReporters(reporters?: Array<ReporterConfig>): boolean {
reporters: [['default', {}], 'someother']
```

This fix, use  the already existing `_getReporterProps` to compare `{path} === 'default'`.
  • Loading branch information
@artola
artola committed Aug 15, 2018
commit 257cc2f800e0711c84cfae75d4d10b6f27bd5223
16 changes: 7 additions & 9 deletions packages/jest-cli/src/TestScheduler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,10 +255,10 @@ export default class TestScheduler {
}
}

_shouldAddDefaultReporters(reporters?: Array<ReporterConfig>): boolean {
_shouldAddDefaultReporters(reporters?: Array<string | ReporterConfig>): boolean {
return (
!reporters ||
!!reporters.find(reporterConfig => reporterConfig[0] === 'default')
!!reporters.find(reporter => this._getReporterProps(reporter).path === 'default')
);
}

Expand Down Expand Up @@ -303,13 +303,11 @@ export default class TestScheduler {
this.addReporter(new SummaryReporter(this._globalConfig));
}

_addCustomReporters(reporters: Array<ReporterConfig>) {
const customReporters = reporters.filter(
reporterConfig => reporterConfig[0] !== 'default',
);

customReporters.forEach((reporter, index) => {
_addCustomReporters(reporters: Array<string | ReporterConfig>) {
reporters.forEach((reporter, index) => {
const {options, path} = this._getReporterProps(reporter);

if (path === 'default') return;

try {
// $FlowFixMe
Expand All @@ -331,7 +329,7 @@ export default class TestScheduler {
* to make dealing with them less painful.
*/
_getReporterProps(
reporter: ReporterConfig,
reporter: string | ReporterConfig,
): {path: string, options?: Object} {
if (typeof reporter === 'string') {
return {options: this._options, path: reporter};
Expand Down