Skip deploy website if it is a pull request #6590
Conversation
endiliey
changed the title
Codecov Report
@@ Coverage Diff @@
## master #6590 +/- ##
=======================================
Coverage 63.73% 63.73%
=======================================
Files 235 235
Lines 8931 8931
Branches 4 3 -1
=======================================
Hits 5692 5692
Misses 3238 3238
Partials 1 1Continue to review full report at Codecov.
|
|
Is it possible to fix the
|
endiliey
changed the title
| working_directory: ~/jest | ||
| docker: | ||
| - image: circleci/node:8 | ||
| resource_class: large |
There was a problem hiding this comment.
We can bump our test workers from -w=2 to -w=4 in package.json
There was a problem hiding this comment.
That in particular is just website build, isn't it? Might be worth doing for the test runs of course
rickhanlonii
left a comment
rickhanlonii
left a comment
There was a problem hiding this comment.
LGTM, would recommend bumping the number of workers we use in tests as well 👍
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
5 participants
Summary
Current CircleCI integration is such that it will install docusaurus, generate english file for strings & then install jre -> install crowdin -> upload crowdin docs -> download crowdin docs -> try to deploy website regardless whether it is a pull request or not.
I think it is much better to skip deploying the website if it is just a pull request & only deploy when it has been pushed to master.
Another change is addition of large resource class for website deploy based on #6567 (comment)
Test plan
Look at circleci jobs of test-deploy-website for this PR.