Skip to content

fix: add console error to catch block #6665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
J-Dickson wants to merge 2 commits into from
Closed

fix: add console error to catch block #6665

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b47ff10
fix: add console error to catch block
Jul 10, 2018
2c07aa7
add changelog entry
Jul 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: add console error to catch block
  • Loading branch information
Jonathon Dickson committed Jul 10, 2018
commit b47ff106cb9a98beb3c953913aa753aa3421daaf
4 changes: 3 additions & 1 deletion packages/jest-resolve-dependencies/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ class DependencyResolver {
}
try {
return this._resolver.resolveModule(file, dependency, options);
} catch (e) {}
} catch (e) {
console.error(e);
Copy link
Member

@SimenB SimenB Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we fallback to mock module here... I think a better approach would be to just rethrow the error unless we want to fetch the mock.

}
return this._resolver.getMockModule(file, dependency);
})
.filter(Boolean);
Expand Down