Skip to content

perf(changed-files): limit git and hg commands to specified roots #6732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 5 commits into from
Jul 21, 2018
Merged

perf(changed-files): limit git and hg commands to specified roots #6732

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
33acece
perf(changed-files): limit git and hg commands to specified roots
booleanbetrayal Jul 20, 2018
aac709c
move roots into Options as optional property and always provide via g…
booleanbetrayal Jul 20, 2018
8521eb4
remove redundant root
booleanbetrayal Jul 20, 2018
dcec626
drop the shoulds
booleanbetrayal Jul 20, 2018
3647446
"monitors only" instead of "monitors" in test labels
booleanbetrayal Jul 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
drop the shoulds
  • Loading branch information
@booleanbetrayal
booleanbetrayal authored Jul 20, 2018
commit dcec62661e5865e5b8eb8c47bbfd87fc9906807e
4 changes: 2 additions & 2 deletions e2e/__tests__/jest_changed_files.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ test('gets changed files for git', async () => {
).toEqual(['file5.txt']);
});

test('should only monitor root paths for git', async () => {
test('monitors root paths for git', async () => {
writeFiles(DIR, {
'file1.txt': 'file1',
'nested_dir/file2.txt': 'file2',
Expand Down Expand Up @@ -346,7 +346,7 @@ test('gets changed files for hg', async () => {
).toEqual(['file5.txt']);
});

test('should only monitor root paths for hg', async () => {
test('monitors root paths for hg', async () => {
if (process.env.CI) {
// Circle and Travis have very old version of hg (v2, and current
// version is v4.2) and its API changed since then and not compatible
Expand Down