Skip to content

[jest-each]: Add flag to prevent done callback being supplied to describe #6843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimenB merged 3 commits into from
Aug 18, 2018
Merged

[jest-each]: Add flag to prevent done callback being supplied to describe #6843

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01aef2f
Add flag to prevent done callback being supplied to describe
mattphillips Aug 14, 2018
0a81b2f
Add changelog entry
mattphillips Aug 14, 2018
9979f0e
Refactor with thymikee linter ;)
mattphillips Aug 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Refactor with thymikee linter ;)
  • Loading branch information
@mattphillips
mattphillips committed Aug 14, 2018
commit 9979f0e119c9834ae18452e92fd43001bb6913f2
17 changes: 6 additions & 11 deletions packages/jest-each/src/bind.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,12 +119,10 @@ const applyRestParams = (
supportsDone: boolean,
params: Array<any>,
test: Function,
) => {
if (supportsDone && params.length < test.length)
return done => test(...params, done);

return () => test(...params);
};
) =>
supportsDone && params.length < test.length
? done => test(...params, done)
: () => test(...params);

const getHeadingKeys = (headings: string): Array<string> =>
headings.replace(/\s/g, '').split('|');
Expand Down Expand Up @@ -157,11 +155,8 @@ const interpolate = (title: string, data: any) =>
.reduce(getMatchingKeyPaths(title), []) // aka flatMap
.reduce(replaceKeyPathWithValue(data), title);

const applyObjectParams = (supportsDone: boolean, obj: any, test: Function) => {
if (supportsDone && test.length > 1) return done => test(obj, done);

return () => test(obj);
};
const applyObjectParams = (supportsDone: boolean, obj: any, test: Function) =>
supportsDone && test.length > 1 ? done => test(obj, done) : () => test(obj);

const pluralize = (word: string, count: number) =>
word + (count === 1 ? '' : 's');
Expand Down