Skip to content

Throw a descriptive error if the first argument supplied to a hook was not a function #6917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimenB merged 6 commits into from
Aug 30, 2018
Merged

Throw a descriptive error if the first argument supplied to a hook was not a function #6917

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b15b03d
throw a descriptive error if the first argument supplied to a hook wa…
ranyitz Aug 29, 2018
11f23d6
remove jest_v21 flow-typed definition file
ranyitz Aug 29, 2018
9d83f64
update changelog
ranyitz Aug 29, 2018
3ef5e92
Update hooks_error.test.js
SimenB Aug 30, 2018
eb2f796
Update hooks_error.test.js
SimenB Aug 30, 2018
dab37ed
make flow happy
SimenB Aug 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update hooks_error.test.js
  • Loading branch information
@SimenB
SimenB authored Aug 30, 2018
commit 3ef5e926385ff6b1c104c712c16825fc06d3e21a
4 changes: 2 additions & 2 deletions packages/jest-circus/src/__tests__/hooks_error.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@
const circus = require('../index.js');

describe('hooks error throwing', () => {
test.each([['beforeEach'], ['beforeAll'], ['afterEach'], ['afterAll']])(
test.each(['beforeEach', 'beforeAll', 'afterEach', 'afterAll'])(
'%s throws an error when the first argument is not a function',
fn => {
expect(() => {
circus[fn]('param');
}).toThrowError(
`Invalid first argument, param. It must be a callback function.`,
'Invalid first argument, param. It must be a callback function.',
);
},
);
Expand Down