Skip to content

Conversation

@quisido
Copy link
Contributor

@quisido quisido commented Sep 20, 2018

Summary

resolves #6430

Omitting a test function it('should') should default to it.skip('should'), not throw an error.

Test Plan

Here it is running locally, and correctly skipping tests with no second parameter.

image

@SimenB
Copy link
Member

SimenB commented Sep 20, 2018

Thanks for the PR! We'll probably be going for #6996 instead though

@javorosas
Copy link

javorosas commented Sep 27, 2018

Why not both?

it('should write less code')

could be an alias for:

it.todo('should write less code')

it even makes more sense when you read it

@SimenB
Copy link
Member

SimenB commented Sep 29, 2018

See #6602 (comment).

Thanks for the PR, though!

@SimenB SimenB closed this Sep 29, 2018
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Excluding second argument should not throw, but instead mark the test as skipped

4 participants