Skip to content

expect: Improve report when assertion fails, part 3 #7152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 11 commits into from
Dec 28, 2018
Merged

expect: Improve report when assertion fails, part 3 #7152

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6938483
expect: Improve report when assertion fails, part 3
pedrottimark Oct 12, 2018
fca74b6
Display lines of labeled values as two columns with monospace alignment
pedrottimark Oct 15, 2018
2bcac8b
Merge and then update CHANGELOG.md
pedrottimark Oct 15, 2018
d187626
Merge branch 'master' into improve-report-3
pedrottimark Oct 15, 2018
8e11f7f
Add test for getLabelPrinter
pedrottimark Oct 15, 2018
1cf4745
Include received type in label for toHaveLength matcher
pedrottimark Oct 15, 2018
aeb0c5d
Fix pretty lint error
pedrottimark Oct 15, 2018
22f0263
Refactor message function in toContain and toContainEqual
pedrottimark Oct 15, 2018
2973754
Align values for toBeCloseTo
pedrottimark Oct 15, 2018
6b2f202
Resolve merge conflicts
pedrottimark Dec 22, 2018
dd45440
Resolve merge conflict
pedrottimark Dec 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test for getLabelPrinter
  • Loading branch information
@pedrottimark
pedrottimark committed Oct 15, 2018
commit 8e11f7ff8465efffa52becf8d07cb7c45c0da9d7
8 changes: 8 additions & 0 deletions packages/jest-matcher-utils/src/__tests__/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,14 @@ describe('getLabelPrinter', () => {
expect(printLabel(stringExpected)).toBe('Expected value: ');
expect(printLabel(stringReceived)).toBe('Received set: ');
});
test('returns incorrect padding if inconsistent arg is shorter', () => {
const stringConsistent = 'Expected';
const stringInconsistent = 'Received value';
const stringInconsistentShorter = 'Received set';
const printLabel = getLabelPrinter(stringConsistent, stringInconsistent);
expect(printLabel(stringConsistent)).toBe('Expected: ');
expect(printLabel(stringInconsistentShorter)).toBe('Received set: ');
});
test('throws if inconsistent arg is longer', () => {
const stringConsistent = 'Expected';
const stringInconsistent = 'Received value';
Expand Down