Skip to content

expect: Improve report when matcher fails, part 8 #7876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimenB merged 3 commits into from
Feb 13, 2019
Merged

expect: Improve report when matcher fails, part 8 #7876

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90b9083
expect: Improve report when matcher fails, part 8
pedrottimark Feb 12, 2019
d5789de
Update CHANGELOG.md
pedrottimark Feb 12, 2019
52dffd0
Ordinary conversion makes it easier to compare differences
pedrottimark Feb 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Ordinary conversion makes it easier to compare differences
  • Loading branch information
@pedrottimark
pedrottimark committed Feb 12, 2019
commit 52dffd016da642350b71f72911957cdd330f0f89
50 changes: 25 additions & 25 deletions packages/expect/src/__tests__/__snapshots__/matchers.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ Expected: <green>-1.23</>
Received: <red>-Infinity</>

Expected precision: <green>2</>
Expected difference: < <green>5e-3</>
Expected difference: < <green>0.005</>
Received difference: <red>Infinity</>"
`;

Expand All @@ -406,7 +406,7 @@ Expected: <green>-Infinity</>
Received: <red>Infinity</>

Expected precision: <green>2</>
Expected difference: < <green>5e-3</>
Expected difference: < <green>0.005</>
Received difference: <red>Infinity</>"
`;

Expand All @@ -417,7 +417,7 @@ Expected: <green>1.23</>
Received: <red>Infinity</>

Expected precision: <green>2</>
Expected difference: < <green>5e-3</>
Expected difference: < <green>0.005</>
Received difference: <red>Infinity</>"
`;

Expand All @@ -442,8 +442,8 @@ Expected: not <green>0.001</>
Received: <red>0</>

Expected precision: <green>2</>
Expected difference: not < <green>5e-3</>
Received difference: <red>1e-3</>"
Expected difference: not < <green>0.005</>
Received difference: <red>0.001</>"
`;

exports[`.toBeCloseTo() {pass: true} expect(1.23)toBeCloseTo( 1.225) 1`] = `
Expand All @@ -453,8 +453,8 @@ Expected: not <green>1.225</>
Received: <red>1.23</>

Expected precision: <green>2</>
Expected difference: not < <green>5e-3</>
Received difference: <red>4.999999999999893e-3</>"
Expected difference: not < <green>0.005</>
Received difference: <red>0.004999999999999893</>"
`;

exports[`.toBeCloseTo() {pass: true} expect(1.23)toBeCloseTo( 1.226) 1`] = `
Expand All @@ -464,8 +464,8 @@ Expected: not <green>1.226</>
Received: <red>1.23</>

Expected precision: <green>2</>
Expected difference: not < <green>5e-3</>
Received difference: <red>4.0000000000000036e-3</>"
Expected difference: not < <green>0.005</>
Received difference: <red>0.0040000000000000036</>"
`;

exports[`.toBeCloseTo() {pass: true} expect(1.23)toBeCloseTo( 1.229) 1`] = `
Expand All @@ -475,8 +475,8 @@ Expected: not <green>1.229</>
Received: <red>1.23</>

Expected precision: <green>2</>
Expected difference: not < <green>5e-3</>
Received difference: <red>9.999999999998899e-4</>"
Expected difference: not < <green>0.005</>
Received difference: <red>0.0009999999999998899</>"
`;

exports[`.toBeCloseTo() {pass: true} expect(1.23)toBeCloseTo( 1.234) 1`] = `
Expand All @@ -486,8 +486,8 @@ Expected: not <green>1.234</>
Received: <red>1.23</>

Expected precision: <green>2</>
Expected difference: not < <green>5e-3</>
Received difference: <red>4.0000000000000036e-3</>"
Expected difference: not < <green>0.005</>
Received difference: <red>0.0040000000000000036</>"
`;

exports[`.toBeCloseTo() {pass: true} expect(Infinity)toBeCloseTo( Infinity) 1`] = `
Expand All @@ -504,8 +504,8 @@ Expected: not <green>0.000004</>
Received: <red>0</>

Expected precision: <green>5</>
Expected difference: not < <green>5e-6</>
Received difference: <red>4e-6</>"
Expected difference: not < <green>0.000005</>
Received difference: <red>0.000004</>"
`;

exports[`.toBeCloseTo() accepts an optional precision argument: [0, 0.0001, 3] 1`] = `
Expand All @@ -515,8 +515,8 @@ Expected: not <green>0.0001</>
Received: <red>0</>

Expected precision: <green>3</>
Expected difference: not < <green>5e-4</>
Received difference: <red>1e-4</>"
Expected difference: not < <green>0.0005</>
Received difference: <red>0.0001</>"
`;

exports[`.toBeCloseTo() accepts an optional precision argument: [0, 0.1, 0] 1`] = `
Expand All @@ -526,8 +526,8 @@ Expected: not <green>0.1</>
Received: <red>0</>

Expected precision: <green>0</>
Expected difference: not < <green>5e-1</>
Received difference: <red>1e-1</>"
Expected difference: not < <green>0.5</>
Received difference: <red>0.1</>"
`;

exports[`.toBeCloseTo() throws: [0, 0.01] 1`] = `
Expand All @@ -537,8 +537,8 @@ Expected: <green>0.01</>
Received: <red>0</>

Expected precision: <green>2</>
Expected difference: < <green>5e-3</>
Received difference: <red>1e-2</>"
Expected difference: < <green>0.005</>
Received difference: <red>0.01</>"
`;

exports[`.toBeCloseTo() throws: [1, 1.23] 1`] = `
Expand All @@ -548,8 +548,8 @@ Expected: <green>1.23</>
Received: <red>1</>

Expected precision: <green>2</>
Expected difference: < <green>5e-3</>
Received difference: <red>2.2999999999999998e-1</>"
Expected difference: < <green>0.005</>
Received difference: <red>0.22999999999999998</>"
`;

exports[`.toBeCloseTo() throws: [1.23, 1.2249999] 1`] = `
Expand All @@ -559,8 +559,8 @@ Expected: <green>1.2249999</>
Received: <red>1.23</>

Expected precision: <green>2</>
Expected difference: < <green>5e-3</>
Received difference: <red>5.000099999999952e-3</>"
Expected difference: < <green>0.005</>
Received difference: <red>0.005000099999999952</>"
`;

exports[`.toBeDefined(), .toBeUndefined() '"a"' is defined 1`] = `
Expand Down
16 changes: 4 additions & 12 deletions packages/expect/src/matchers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,25 +121,17 @@ const matchers: MatchersObject = {
: `Received: ${printReceived(received)}\n` +
'\n' +
`Expected precision: ${printExpected(precision)}\n` +
`Expected difference: not < ${EXPECTED_COLOR(
expectedDiff.toExponential(),
)}\n` +
`Received difference: ${RECEIVED_COLOR(
receivedDiff.toExponential(),
)}`)
`Expected difference: not < ${printExpected(expectedDiff)}\n` +
`Received difference: ${printReceived(receivedDiff)}`)
: () =>
matcherHint('toBeCloseTo', undefined, undefined, options) +
'\n\n' +
`Expected: ${printExpected(expected)}\n` +
`Received: ${printReceived(received)}\n` +
'\n' +
`Expected precision: ${printExpected(precision)}\n` +
`Expected difference: < ${EXPECTED_COLOR(
expectedDiff.toExponential(),
)}\n` +
`Received difference: ${RECEIVED_COLOR(
receivedDiff.toExponential(),
)}`;
`Expected difference: < ${printExpected(expectedDiff)}\n` +
`Received difference: ${printReceived(receivedDiff)}`;

return {message, pass};
},
Expand Down