Skip to content

Conversation

guyyb
Copy link
Contributor

@guyyb guyyb commented Jun 16, 2022

I have read the CLA Document and I hereby sign the CLA

@github-actions
Copy link

github-actions bot commented Jun 16, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@guyyb
Copy link
Contributor Author

guyyb commented Jun 16, 2022

I have read the CLA Document and I hereby sign the CLA

@guyyb
Copy link
Contributor Author

guyyb commented Jun 16, 2022

recheck

Fixed missing space in gradle config
@yahavi yahavi self-assigned this Jun 23, 2022
@yahavi yahavi changed the title Guy add gitlab Add GitLab example Jul 9, 2022
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my inline comments and also -
In our examples, we usually add all tools needed to run the example. I'm not sure about this one, but please consider adding a simple Gradle project to this project.

@guyyb
Copy link
Contributor Author

guyyb commented Jul 10, 2022

Hi Yahav,
Accepted all of your comments, and added a link to the spring-petclinic project, I used to test this example

@guyyb
Copy link
Contributor Author

guyyb commented Jul 10, 2022

Sorry, missed a few comments.
Accepted all but 2, see comments added.

@guyyb guyyb requested a review from yahavi July 11, 2022 13:31
@yahavi yahavi merged commit 66d9560 into jfrog:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants