Name Mangling Fix, and update CI/CD, and package setup #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… name to prevent the mangling, and breaking on Python on a computer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw an issue where name mangling was breaking the PyPi version, so went to fix that. Alongside converting the package from using setup.py to a pyproject.toml since the prior is deprecated, and soon to be removed as a fallback.
Then while there also updated the CI/CD actions to more closely match the current CircuitPython requested library implementation, but still leaving out the
docs/publishing portion since that was commented out, along with thereusemodule in pre-commit.The build action has been tested, but the release action has not been.