-
Notifications
You must be signed in to change notification settings - Fork 335
add init tip distribution account functionality in between epochs #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
04e08f8 to
cc5fe2e
Compare
whistlinwilly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for delay ser
buffalu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initial review. main points:
- i don't think we need tip manager to be locked?
- do we need to store mutable state in tip_manager? i think we can get away without it.
- nits
fece3d6 to
5b20f7a
Compare
f8b7e53 to
1cbf062
Compare
buffalu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few smaller comments, most of it seems gucci mane
35ed2c7 to
b88fd52
Compare
1eb3a17 to
e9dbdde
Compare
7476b8c to
851aeed
Compare
851aeed to
8f88f2a
Compare
Problem
We want initialize a validator's
TipDistributionAccount(TDA) in between epochs.Summary of Changes
Upon startup a validator initializes the
TipManagerobject, which in turn creates an in memory TDA. There is no tx propagated to the network initializing it with the program until the validator is leader. Each slot the validator is a leader for, it'll check to see if it should init the TDA on-chain.The logic is as follows:
maybe_init_config tx(existing code).tip_receiver == my_tda, if not then submit a tx to the network as TOB or 2nd of Block to change tip-receiver to the validator's current epoch TDA