Skip to content

Bam Writer Service, Kobe API: Remove metrics table#61

Draft
aoikurokawa wants to merge 2 commits into
masterfrom
ak/metrics
Draft

Bam Writer Service, Kobe API: Remove metrics table#61
aoikurokawa wants to merge 2 commits into
masterfrom
ak/metrics

Conversation

@aoikurokawa

Copy link
Copy Markdown
Collaborator

No description provided.

@aoikurokawa aoikurokawa changed the title Bam Writer Service: Remove metrics table Bam Writer Service, Kobe API: Remove metrics table Jun 2, 2026
@aoikurokawa aoikurokawa requested a review from Copilot June 2, 2026 19:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the BAM epoch metrics persistence and exposure from the codebase, eliminating the associated DB model/table usage and the public API endpoint that served it.

Changes:

  • Removed the bam_epoch_metrics DB model/store from kobe_core and stopped writing epoch metrics from bam-writer-service.
  • Deleted the BAM delegation criteria module (and its tests) that depended on epoch metrics history.
  • Removed the /api/v1/bam_epoch_metrics API route, request/response schema, and resolver logic from kobe_api.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
core/src/db_models/mod.rs Stops exporting the removed bam_epoch_metrics DB model module.
core/src/db_models/bam_epoch_metrics.rs Deletes the epoch metrics model + MongoDB store implementation.
bam-writer-service/src/lib.rs Removes epoch metrics persistence/allocation calculations; keeps only BAM validator upsert + datapoints.
bam-writer-service/src/bam_delegation_criteria.rs Deletes the delegation allocation logic and unit tests that relied on epoch metrics.
api/src/schemas/mod.rs Stops exporting the removed BAM epoch metrics schema module.
api/src/schemas/bam_epoch_metrics.rs Deletes request/response schema for the removed endpoint.
api/src/resolvers/query_resolver.rs Removes the cached wrapper + resolver method + store field for BAM epoch metrics.
api/src/main.rs Removes the /api/v1/bam_epoch_metrics handler and route wiring.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread bam-writer-service/src/lib.rs Outdated
Comment thread bam-writer-service/src/lib.rs Outdated
Comment thread bam-writer-service/src/lib.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants