Bam Writer Service, Kobe API: Remove metrics table#61
Draft
aoikurokawa wants to merge 2 commits into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the BAM epoch metrics persistence and exposure from the codebase, eliminating the associated DB model/table usage and the public API endpoint that served it.
Changes:
- Removed the
bam_epoch_metricsDB model/store fromkobe_coreand stopped writing epoch metrics frombam-writer-service. - Deleted the BAM delegation criteria module (and its tests) that depended on epoch metrics history.
- Removed the
/api/v1/bam_epoch_metricsAPI route, request/response schema, and resolver logic fromkobe_api.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| core/src/db_models/mod.rs | Stops exporting the removed bam_epoch_metrics DB model module. |
| core/src/db_models/bam_epoch_metrics.rs | Deletes the epoch metrics model + MongoDB store implementation. |
| bam-writer-service/src/lib.rs | Removes epoch metrics persistence/allocation calculations; keeps only BAM validator upsert + datapoints. |
| bam-writer-service/src/bam_delegation_criteria.rs | Deletes the delegation allocation logic and unit tests that relied on epoch metrics. |
| api/src/schemas/mod.rs | Stops exporting the removed BAM epoch metrics schema module. |
| api/src/schemas/bam_epoch_metrics.rs | Deletes request/response schema for the removed endpoint. |
| api/src/resolvers/query_resolver.rs | Removes the cached wrapper + resolver method + store field for BAM epoch metrics. |
| api/src/main.rs | Removes the /api/v1/bam_epoch_metrics handler and route wiring. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.