FR: Add a verbose option to `jj git fetch`, (`jj git fetch --verbose`)

[PhilipMetzger]

Is your feature request related to a problem? Please describe.
This was requested by Julia Evans in Discord, it should display all the things jj git fetch does and the commits it abandoned.

This may help to form a intuition on how Jujutsu works.

[poliorcetics]

There is already a global --verbose that has a wordy output (and that case is when there is nothing to fetch!):

2024-02-18T00:24:14.755214Z  INFO jj_cli::cli_util: verbose logging enabled
2024-02-18T00:24:14.793751Z DEBUG run_command:cmd_git_fetch{args=GitFetchArgs { branch: [Glob(Pattern { original: "*", tokens: [AnySequence], is_recursive: false })], remotes: [], all_remotes: false }}:fetch{remote_name="origin" branch_names=[Glob(Pattern { original: "*", tokens: [AnySequence], is_recursive: false })] git_settings=GitSettings { auto_local_branch: false, abandon_unreachable_commits: true }}: jj_lib::git: remote.download
2024-02-18T00:24:21.623910Z  INFO run_command:cmd_git_fetch{args=GitFetchArgs { branch: [Glob(Pattern { original: "*", tokens: [AnySequence], is_recursive: false })], remotes: [], all_remotes: false }}:fetch{remote_name="origin" branch_names=[Glob(Pattern { original: "*", tokens: [AnySequence], is_recursive: false })] git_settings=GitSettings { auto_local_branch: false, abandon_unreachable_commits: true }}: jj_lib::git: trying ssh_key_from_agent username="git"
2024-02-18T00:24:22.368696Z DEBUG run_command:cmd_git_fetch{args=GitFetchArgs { branch: [Glob(Pattern { original: "*", tokens: [AnySequence], is_recursive: false })], remotes: [], all_remotes: false }}:fetch{remote_name="origin" branch_names=[Glob(Pattern { original: "*", tokens: [AnySequence], is_recursive: false })] git_settings=GitSettings { auto_local_branch: false, abandon_unreachable_commits: true }}: jj_lib::git: remote.prune
2024-02-18T00:24:22.394204Z DEBUG run_command:cmd_git_fetch{args=GitFetchArgs { branch: [Glob(Pattern { original: "*", tokens: [AnySequence], is_recursive: false })], remotes: [], all_remotes: false }}:fetch{remote_name="origin" branch_names=[Glob(Pattern { original: "*", tokens: [AnySequence], is_recursive: false })] git_settings=GitSettings { auto_local_branch: false, abandon_unreachable_commits: true }}: jj_lib::git: remote.update_tips
2024-02-18T00:24:22.395648Z DEBUG run_command:cmd_git_fetch{args=GitFetchArgs { branch: [Glob(Pattern { original: "*", tokens: [AnySequence], is_recursive: false })], remotes: [], all_remotes: false }}:fetch{remote_name="origin" branch_names=[Glob(Pattern { original: "*", tokens: [AnySequence], is_recursive: false })] git_settings=GitSettings { auto_local_branch: false, abandon_unreachable_commits: true }}: jj_lib::git: default_branch="main"
2024-02-18T00:24:22.395656Z DEBUG run_command:cmd_git_fetch{args=GitFetchArgs { branch: [Glob(Pattern { original: "*", tokens: [AnySequence], is_recursive: false })], remotes: [], all_remotes: false }}:fetch{remote_name="origin" branch_names=[Glob(Pattern { original: "*", tokens: [AnySequence], is_recursive: false })] git_settings=GitSettings { auto_local_branch: false, abandon_unreachable_commits: true }}: jj_lib::git: remote.disconnect
2024-02-18T00:24:22.499728Z DEBUG run_command:cmd_git_fetch{args=GitFetchArgs { branch: [Glob(Pattern { original: "*", tokens: [AnySequence], is_recursive: false })], remotes: [], all_remotes: false }}:fetch{remote_name="origin" branch_names=[Glob(Pattern { original: "*", tokens: [AnySequence], is_recursive: false })] git_settings=GitSettings { auto_local_branch: false, abandon_unreachable_commits: true }}: jj_lib::git: import_refs
Nothing changed.

How do we want to improve it ?

[martinvonz]

Maybe we should rename the current --verbose to --debug

[yuja]

A part of this will be implemented by #3044

[poliorcetics]

Maybe we should rename the current --verbose to --debug

Yes it sounds much better for what it does, I'll open a PR soon

[zummenix]

#3044 is implemented now. jj git fetch now lists new remote branches and tags. I like it a lot. However, the initial FR is to list commits that were abandoned during fetch if --verbose flag is present. Are there any suggestions or recommendations what information is important to print for an abandoned commit? I think change id and first line of a commit description would be useful. Interested to hear what others think.

[yuja]

the initial FR is to list commits that were abandoned during fetch if --verbose flag is present.

Maybe we can resurrect 902a43a. The output format is the same as jj abandon.

[MrTact]

I'm going to propose something here... this may not actually be what we want.

Personally, I don't know that I would use this flag a lot. I noticed today doing a jj git fetch that I had a lot of abandoned commits, but by then, it was too late for me to opt in to seeing them listed as part of the output from the fetch. It seems to me that the philosophy of jujutsu is to not put you into a position where you have to compose some elaborate git query in order to figure something out. So maybe an easy command to list the abandoned commits post facto instead?

[PhilipMetzger]

Personally, I don't know that I would use this flag a lot. I noticed today doing a jj git fetch that I had a lot of abandoned commits, but by then, it was too late for me to opt in to seeing them listed as part of the output from the fetch. It seems to me that the philosophy of jujutsu is to not put you into a position where you have to compose some elaborate git query in order to figure something out. So maybe an easy command to list the abandoned commits post facto instead?

I'd argue that a --verbose option is always a niche use-case, but that should not mean that it should be moved to a separate command. It should be enough if we get a message why the commit was abandoned after a jj git fetch --verbose.

[joshka]

I'd argue that a --verbose option is always a niche use-case, but that should not mean that it should be moved to a separate command. It should be enough if we get a message why the commit was abandoned after a jj git fetch --verbose.

I'm in strong disagreement with that --verbose is a niche use case. This is a standard flag that many cli tools support. It's so standard that it's what people will will likely reach for when looking to understand why something didn't act the way that they expected. Not having it doubles down on being different from expectations.

I think it was a mistake to rename this flag to --debug - added a more general issue around that over at #8572