Skip to content

dag_walk: convert topo_order_* functions to async #9046

Open
bnjmnt4n wants to merge 2 commits intomainfrom
bnjmnt4n/push-skvvymzmmxon
Open

dag_walk: convert topo_order_* functions to async #9046
bnjmnt4n wants to merge 2 commits intomainfrom
bnjmnt4n/push-skvvymzmmxon

Conversation

@bnjmnt4n
Copy link
Member

@bnjmnt4n bnjmnt4n commented Mar 7, 2026

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added/updated tests to cover my changes
  • I fully understand the code that I am submitting (what it does,
    how it works, how it's organized), including any code drafted by AI
  • For any prose generated by AI, I have proof-read and copy-edited with an
    eye towards deleting anything that is irrelevant, clarifying anything that
    is confusing, and adding details that are relevant. This includes, for
    example, commit descriptions, PR descriptions, and code comments.

@bnjmnt4n bnjmnt4n requested a review from a team as a code owner March 7, 2026 21:21
@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-skvvymzmmxon branch from 755e81c to c711298 Compare March 7, 2026 21:58
@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-skvvymzmmxon branch from c711298 to 879589f Compare March 7, 2026 22:31
@bnjmnt4n
Copy link
Member Author

bnjmnt4n commented Mar 8, 2026

Due to the virality of async functions, converting dag_walk to async seems like it’s almost required at this point. I guess this is a major change, but I’m not sure if there are any other options (apart from maintaining a sync version with block_on if desired)?

@yuja
Copy link
Contributor

yuja commented Mar 8, 2026

Due to the virality of async functions, converting dag_walk to async seems like it’s almost required at this point. I guess this is a major change, but I’m not sure if there are any other options (apart from maintaining a sync version with block_on if desired)?

Maybe we have to use macro to strip off async/.await from blocking versions? It seems bad that we have to mark pure computation functions as async just because the underlying utility is unnecessarily async. Using .block_on() under the hood is equally bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants