Open
Conversation
This fixes issue jj-vcs#8673 where would fail because the revset parser did not accept double dashes in bookmark names. The grammar has been updated to allow: - Consecutive '-' and '+' characters (e.g., foo--bar, foo++bar, foo+-bar) - Mixed patterns with '.' (e.g., foo.-bar, foo.+bar) The '..' sequence is still NOT allowed as part of an identifier because it's the range operator. So 'foo..bar' is still parsed as a range from 'foo' to 'bar'. Added tests for: - Parser-level identifier tests for double/triple dashes - CLI-level test for git push --named with double dashes Closes jj-vcs#8673 Co-authored-by: 2020.raj.pabnani <2020.raj.pabnani@ves.ac.in>
Co-authored-by: Raj_Pabnani <RajPabnani03@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
The following commits do not follow our format for subject lines:
- 9287d4f: Fix UTF-8 hex escapes in string literals
Commits should have a subject line following the format <topic>: <description>. Please review the commit guidelines for more information.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)how it works, how it's organized), including any code drafted by AI
eye towards deleting anything that is irrelevant, clarifying anything that
is confusing, and adding details that are relevant. This includes, for
example, commit descriptions, PR descriptions, and code comments.