Conversation
Assisted-by: Opus 4.6 via Claude Code Signed-off-by: Austin Seipp <aseipp@pobox.com>
Assisted-by: Opus 4.6 via Claude Code Signed-off-by: Austin Seipp <aseipp@pobox.com>
| commit_builder.set_author(new_author); | ||
| } | ||
| commit_builder | ||
| }) |
There was a problem hiding this comment.
Does it work to still call .map() but with an async closure and then wrap the whole think in try_join_all()? We've done that in lots of other places. It would mean that the commits are written concurrently if the backend supports it.
There was a problem hiding this comment.
(Non-actionable, also mostly just wrong) I only glanced at this, but it sounds a bit similar to what I'm doing in #9087 maybe: create a stream of futures, and then convert it into a stream of outputs of these futures via .buffered.
I am not sure I whole-heatedly recommend it at this point, it does seem to add complexity.
Update: I think I misunderstood what Martin said as I started writing this. I'll leave it here, I think the analogy is interesting, but it's less actionable than Martin's comment.
Update 2: The approach of #9087 is not useful here, since you don't need streaming. You need to wait to get all the values before you can do anything with them.
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)how it works, how it's organized), including any code drafted by an LLM.
an eye towards deleting anything that is irrelevant, clarifying anything
that is confusing, and adding details that are relevant. This includes,
for example, commit descriptions, PR descriptions, and code comments.