Skip to content

tests: replace many .unwrap()s with ?s using eyre #9111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
glehmann wants to merge 7 commits into
base: main
Choose a base branch
from
+4,817 −4,936
Open

tests: replace many .unwrap()s with ?s using eyre #9111

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
465c748
testutils: use eyre::Result as TestResult
glehmann Mar 14, 2026
b202110
testutils: use color-eyre for backtrace display
glehmann Mar 14, 2026
dbdc038
testutils: add custom backtrace frame filter to color-eyre
glehmann Mar 15, 2026
c9b89b3
testutils: enable backtrace capture by default (RUST_BACKTRACE=1) in …
glehmann Mar 15, 2026
80ee629
tests: `.block_on().unwrap()` with `.block_on()?` in tests using Test…
ilyagr Mar 14, 2026
e758f76
tests: Replace another ~600 `unwrap()`s in tests with `?`
ilyagr Mar 14, 2026
3b5a9a7
tests: Replace Result.unwrap with ? operator in test functions
glehmann Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
testutils: enable backtrace capture by default (RUST_BACKTRACE=1) in … 
…tests

So backtraces are shown without requiring the environment variable.
  • Loading branch information
@glehmann
glehmann committed Mar 18, 2026
commit c9b89b37f0727fa4c1fe3706c842dfcef1c0e028
7 changes: 7 additions & 0 deletions lib/testutils/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,13 @@ pub mod test_backend;

#[ctor::ctor]
fn init_color_eyre() {
// Enable backtrace capture by default in tests
if std::env::var("RUST_BACKTRACE").is_err() {
Copy link
Contributor

@ilyagr ilyagr Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Probably no action needed) I have two worries about this:

  • Can ctor support this on all systems? AFAIU, it's only supposed to use libc. OTOH, if this passes CI, it probably works.
  • I'm not 100% sure we want this. But it's probably better? I'm up for trying it and seeing if it makes anyone unhappy.

unsafe {
std::env::set_var("RUST_BACKTRACE", "1");
}
}

drop(
color_eyre::config::HookBuilder::default()
.add_frame_filter(Box::new(|frames| {
Expand Down