proc-macros: simplistic regression test for cd960361#9126
Open
proc-macros: simplistic regression test for cd960361#9126
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ilyagr
force-pushed
the
ig/digest-test
branch
2 times, most recently
from
ea24bb8 to
87c1c93
Compare
String-based check that people don't use `digest::` inside the proc-macros crate, so that other crates using jj-lib can use `#[derive(ContentHash)]`.
github-actions
bot
dismissed
their stale review
All commits are now correctly formatted. Thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String-based check that people don't use
digest::inside the proc-macros crate, so that other crates using jj-lib can use#[derive(ContentHash)].Follows up on cd96036.
Example failure: https://github.com/jj-vcs/jj/actions/runs/23173922046/job/67331847132?pr=9126
Cc @emesterhazy since I cc-ed the previous pr to you, but no worries if you're doing other things.
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)how it works, how it's organized), including any code drafted by an LLM.
an eye towards deleting anything that is irrelevant, clarifying anything
that is confusing, and adding details that are relevant. This includes,
for example, commit descriptions, PR descriptions, and code comments.